Johan, Comments inline
----- [email protected] wrote: > Hi Srikanth, > > Comments inline. > > / Johan > > -----Original Message----- > From: Srikanth Revanuru [mailto:[email protected]] > Sent: den 18 september 2015 11:01 > To: Johan Mårtensson O; Hans Nordebäck; [email protected]; Hung > Nguyen D > Cc: [email protected] > Subject: Re: [PATCH 17 of 17] pyosaf: Minor fixes to the caps and > interface sample OIs [#1406] > > Johan, > > Nice work. The sample applications depict the usage of different > features in IMMOI in a simple way. > Johan: Thanks. > > Here are couple of comments. > > -> The file python/pyosaf/utils/immoi/Makefile.am is not part of > patch > sent. Because of which, compilation fails. > Johan: Can you check this after applying all the patches? I think Hung > gave the same comment earlier and it should be fixed in one of the > latest patches. [ Srikanth ]: I stored the old patch 0/9, for which I missed this change. With the new patch applied, RPMS are built successfully. > > -> As the file python/samples/immoi/samples/README is removed in the > > recent patch, is there any plan > to add the usage of the oi samples to the README. The earlier file has > > detailed steps and expected results > about how to use the sample. > Johan: Yes, I moved these to the python/samples/README file and > aligned with the format there. It should also be in one of the latest > patches so please let me know if you don't find it there. [Srikanth] : Yes, the file python/samples/README is updated with the changes about immoi samples as in existing format. The following information which got removed while moving, would be more helpful for the person trying samples. Use like this: $ tones & $ immcfg -c Do doId=1 (allowed) $ immcfg -c Re reId=1,doId=1 (allowed) $ immcfg -c Do doId=1,reId=1,doId=1 (not allowed) $ immcfg -c Mi miId=1 (not allowed) / Srikanth > > / Srikanth > > On 09/15/2015 06:04 PM, Johan Mårtensson wrote: > > python/samples/caps | 6 +++--- > > python/samples/caps-inheritance-impl | 6 +++--- > > python/samples/interface-handler | 2 +- > > 3 files changed, 7 insertions(+), 7 deletions(-) > > > > > > Fix minor issues in the caps and interface sample OIs > > > > diff --git a/python/samples/caps b/python/samples/caps > > --- a/python/samples/caps > > +++ b/python/samples/caps > > @@ -34,9 +34,9 @@ if __name__ == "__main__": > > > > # Parse command line arguments > > parser = argparse.ArgumentParser( > > - description='Validates that the lowerCaps and upperCaps > attributes > > -of instances of the CapsSample class can only contain > > -lower case and upper case text respectively.') > > + description='Validates that the lowerCaps and upperCaps > attributes' > > + 'of instances of the CapsSample class can only contain' > > + 'lower case and upper case text respectively.') > > > > parser.parse_args() > > > > diff --git a/python/samples/caps-inheritance-impl > b/python/samples/caps-inheritance-impl > > --- a/python/samples/caps-inheritance-impl > > +++ b/python/samples/caps-inheritance-impl > > @@ -45,9 +45,9 @@ if __name__ == "__main__": > > > > # Parse command line arguments > > parser = argparse.ArgumentParser( > > - description='Validates that the lowerCaps and upperCaps > attributes > > -of instances of the CapsSample class can only contain > > -lower case and upper case text respectively.') > > + description='Validates that the lowerCaps and upperCaps > attributes' > > + 'of instances of the CapsSample class can only contain' > > + 'lower case and upper case text respectively.') > > > > parser.parse_args() > > > > diff --git a/python/samples/interface-handler > b/python/samples/interface-handler > > --- a/python/samples/interface-handler > > +++ b/python/samples/interface-handler > > @@ -61,7 +61,7 @@ def create_rt_object_for_interface(imple > > implementer.create(mo) > > > > def select_loop(implementer): > > - print 'select loop' > > + > > # Get selection object for the implementer > > selection_object = implementer.get_selection_object() > > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
