Very good work Hung. Ack with a few comments inlined in the relevant patch mails (separate replies).
/AndersBj On 09/18/2015 09:11 AM, Hung Nguyen wrote: > Summary: imm: Add attribute def flag SA_IMM_ATTR_DEFAULT_REMOVED [#1471] > Review request for Trac Ticket(s): 1471 > Peer Reviewer(s): AndersBj, Zoran, Neelakanta > Pull request to: Zoran > Affected branch(es): default(4.7) > Development branch: default(4.7) > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > > changeset c3018766ce418ba14747b1d812a9da802b0fdd4d > Author: Hung Nguyen <[email protected]> > Date: Wed, 09 Sep 2015 11:33:17 +0700 > > imm: Add OPENSAF_IMM_FLAG_PRT47_ALLOW value for noStdFlags [#1471] > > Add OPENSAF_IMM_FLAG_PRT47_ALLOW value for noStdFlags. > > changeset 30f2ca9f9f4f6a8866a3416df87f47b16fbbaf69 > Author: Hung Nguyen <[email protected]> > Date: Wed, 09 Sep 2015 19:31:45 +0700 > > imm: Introduce SA_IMM_ATTR_DEFAULT_REMOVED flag [#1471] > > SA_IMM_ATTR_DEFAULT_REMOVED flag is supported in version A.02.16 or > higher. > > changeset 68918a9bbed9c879cdce5f852d1e5d0b0098a2af > Author: Hung Nguyen <[email protected]> > Date: Wed, 09 Sep 2015 23:07:11 +0700 > > imm: Allow to remove default values as part of schema change [#1471] > > DEFAULT_REMOVED is not allowed for creating new class, only support for > schema change. After removing default values, the default values can be > set > again by using schema change. When an object is created with > default-removed > attribute set to empty, a notice message will be written to syslog. > > changeset 31977393fec0c42cad71a0b20a921ee18333b4f7 > Author: Hung Nguyen <[email protected]> > Date: Wed, 09 Sep 2015 23:13:09 +0700 > > imm: Add support of default value removal to IMM tools [#1471] > > Add support of default value removal to IMM tools. > > changeset d1736b31abe74bf72402e8bf960bed45cbf93755 > Author: Hung Nguyen <[email protected]> > Date: Fri, 11 Sep 2015 15:54:27 +0700 > > imm: Add test cases for default value removal [#1471] > > Add test cases for default value removal. > > > Added Files: > ------------ > osaf/libs/saf/include/saImmOm_A_2_16.h > osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.16.xsd > > > Complete diffstat: > ------------------ > opensaf.spec.in | 1 + > osaf/libs/agents/saf/imma/imma_cb.h | 1 + > osaf/libs/agents/saf/imma/imma_def.h | 2 +- > osaf/libs/agents/saf/imma/imma_oi_api.c | 3 + > osaf/libs/agents/saf/imma/imma_om_api.c | 12 ++ > osaf/libs/common/immsv/immpbe_dump.cc | 3 +- > osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +- > osaf/libs/common/immsv/include/immsv_api.h | 1 + > osaf/libs/saf/include/Makefile.am | 3 +- > osaf/libs/saf/include/saImmOm_A_2_15.h | 2 + > osaf/libs/saf/include/saImmOm_A_2_16.h | 67 > +++++++++++ > osaf/services/saf/immsv/immloadd/imm_loader.cc | 10 +- > osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 2 +- > osaf/services/saf/immsv/immnd/ImmModel.cc | 111 > ++++++++++++++++++- > osaf/services/saf/immsv/immnd/ImmModel.hh | 1 + > osaf/services/saf/immsv/immnd/immnd_evt.c | 17 ++ > osaf/services/saf/immsv/immnd/immnd_init.h | 1 + > osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.16.xsd | 182 > +++++++++++++++++++++++++++++++ > osaf/tools/safimm/immadm/imm_admin.c | 2 +- > osaf/tools/safimm/immcfg/imm_cfg.c | 2 +- > osaf/tools/safimm/immcfg/imm_import.cc | 6 +- > osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 + > osaf/tools/safimm/immfind/imm_find.c | 2 +- > osaf/tools/safimm/immlist/imm_list.c | 8 +- > tests/immsv/common/immtest.c | 4 +- > tests/immsv/management/test_saImmOmClassCreate_2.c | 661 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 26 files changed, 1095 insertions(+), 20 deletions(-) > > > Testing Commands: > ----------------- > Remove default value by adding SA_IMM_ATTR_DEFAULT_REMOVED flag (schema > upgrade). > > > Testing, Expected Results: > -------------------------- > Create an object with the default-removed attribute set to empty. > The value remains empty and a notice message is written to syslog. > > > Conditions of Submission: > ------------------------- > Ack from reviewers. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
