Hi Zoran,

Reviewed and tested the patch.
Ack from me.

Best Regards,

Hung Nguyen - DEK Technologies


--------------------------------------------------------------------------------
From: Zoran Milinkovic [email protected]
Sent: Tuesday, September 22, 2015 6:51PM
To: Neelakanta Reddy
     [email protected]
Cc: Opensaf-devel
     [email protected]
Subject: [devel] [PATCH 1 of 1] imm: fix memory leak in schema upgrade  [#1495]


  osaf/services/saf/immsv/immnd/ImmModel.cc |  1 +
  1 files changed, 1 insertions(+), 0 deletions(-)


When new and old default values are checked in schema upgrade, memory allocated 
by copyValueToEdu() is not freed.
The patch releases allocated memory.

diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc 
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++ b/osaf/services/saf/immsv/immnd/ImmModel.cc
@@ -4136,6 +4136,7 @@ ImmModel::notCompatibleAtt(const std::st
                      className.c_str(), attName.c_str());
                  change = true;
              }
+            immsv_evt_free_att_val(&oldval, 
(SaImmValueTypeT)oldAttr->mValueType);
          }
  
          if(change) {

------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel



------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to