Summary: imm: Add attribute def flag SA_IMM_ATTR_STRONG_DEFAULT [#1425] Review request for Trac Ticket(s): 1425 Peer Reviewer(s): AndersBj, Zoran, Neelakanta Pull request to: Zoran Affected branch(es): default(4.7) Development branch: default(4.7)
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset c26a2c66ec356085c5cb0cbf3a280399214cb86c Author: Hung Nguyen <[email protected]> Date: Tue, 22 Sep 2015 22:45:40 +0700 imm: Introduce SA_IMM_ATTR_STRONG_DEFAULT flag [#1425] SA_IMM_ATTR_STRONG_DEFAULT flag is supported in version A.02.16 or higher. changeset b5cba1f905c22838e8ecb55da3ec81480bbf561e Author: Hung Nguyen <[email protected]> Date: Tue, 22 Sep 2015 23:51:41 +0700 imm: Support SA_IMM_ATTR_STRONG_DEFAULT flag [#1425] This flag is only allowed to be set on attributes that have a default value. Attributes with this flag will never be NULL. Adding this flag to an existing attribute (schema change) will be allowed after checking for ccb interference and existing objects of the class. Do not allow to add a new attribute with this flag when doing schema change. When there's an attempt to set NULL value (or to delete all values with ATTR_VALUES_DELETE) to attributes with this flag, default value will be set. ImmAttrValue::operator= is used to assign value to ImmAttrValue. This will also work with ImmAttrMultiValue (head value will be assigned). changeset e41af138c9f5998737067987d74f00930537d2f9 Author: Hung Nguyen <[email protected]> Date: Tue, 22 Sep 2015 23:53:22 +0700 imm: Add support for strong default to IMM tools [#1425] Add support for strong default to IMM tools. changeset 44bab45928b1cb1016aec6c4142748989e95fc09 Author: Hung Nguyen <[email protected]> Date: Tue, 22 Sep 2015 23:55:01 +0700 imm: Add test cases for strong default [#1425] Add test cases for strong default. Complete diffstat: ------------------ osaf/libs/agents/saf/imma/imma_om_api.c | 6 +++++ osaf/libs/common/immsv/immpbe_dump.cc | 3 +- osaf/libs/saf/include/saImmOm_A_2_16.h | 3 ++ osaf/services/saf/immsv/immloadd/imm_loader.cc | 7 +++++- osaf/services/saf/immsv/immnd/ImmModel.cc | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- osaf/services/saf/immsv/immnd/immnd_evt.c | 8 +++++- osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.16.xsd | 1 + osaf/tools/safimm/immcfg/imm_import.cc | 5 +++- osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +++++++ osaf/tools/safimm/immlist/imm_list.c | 6 +++++ tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c | 6 +++++ tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/immsv/management/test_saImmOmCcbInitialize.c | 6 +++++ tests/immsv/management/test_saImmOmCcbObjectModify_2.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/immsv/management/test_saImmOmClassCreate_2.c | 134 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 15 files changed, 616 insertions(+), 5 deletions(-) Testing Commands: ----------------- Set NULL value to attributes with SA_IMM_ATTR_STRONG_DEFAULT flag. Testing, Expected Results: -------------------------- Default value is set. Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
