Summary: clm: Call plug-in script when an unconfigured node tries to join the 
cluster [#1453]
Review request for Trac Ticket(s): 1453
Peer Reviewer(s): Mathi
Pull request to: 
Affected branch(es): default(4.7)
Development branch: default

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    y
 Build system            n
 RPM/packaging           n
 Configuration files     y
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset e72fa53d3367e17a5e061bb275776f912131bcd1
Author: Anders Widell <[email protected]>
Date:   Mon, 28 Sep 2015 21:24:50 +0200

        clmd: Add support for scale-out by calling a custom script to configure 
new
        nodes [#1453]

        The scale-out feature makes it possible to run a custom script when a 
node
        which is not configured in IMM tries to join the cluster. The intention 
is
        that the custom script will check if the new node is eligible to be 
added to
        the cluster, and if so add the necessary IMM objects so that the node 
will
        be able to join the next time it tries. The script will be called with 
one
        or more arguments, where each argument represents a node which requests 
to
        be added to the cluster. Each argument has the format "X,Y" where X is 
the
        node id in decimal and Y is the name of the node.

        To enable the scale-out feature in CLM, set the CLMSV_SCALE_OUT_SCRIPT
        variable in clmd.conf to point to the executable script which shall be
        executed when new nodes try to join the cluster.

changeset 829a66e896e5bc165426827148cf8cc315350a08
Author: Anders Widell <[email protected]>
Date:   Mon, 28 Sep 2015 21:24:55 +0200

        clmna: Re-try joining the cluster when CLMD returns TRY_AGAIN [#1453]

        When the scale-out feature has been enabled in clmd.conf, CLMD will 
reply
        with the TRY_AGAIN error code instead of the ERR_NOT_EXIST error code 
when a
        node which is not configured tries to join the cluster. CLMNA will 
re-try
        joining the cluster when it receives this new error code.


Complete diffstat:
------------------
 osaf/services/saf/clmsv/README           |   17 +++++++++++
 osaf/services/saf/clmsv/clms/clms_cb.h   |   31 ++++++++++++++++++++
 osaf/services/saf/clmsv/clms/clms_evt.c  |  238 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 osaf/services/saf/clmsv/clms/clms_main.c |   18 +++++++++++
 osaf/services/saf/clmsv/config/clmd.conf |    9 +++++
 osaf/services/saf/clmsv/nodeagent/cb.h   |    4 ++
 osaf/services/saf/clmsv/nodeagent/evt.h  |    2 +
 osaf/services/saf/clmsv/nodeagent/main.c |   70 
+++++++++++++++++++++++++++++++++++++++++++-
 8 files changed, 384 insertions(+), 5 deletions(-)


Testing Commands:
-----------------
Enable the feature by setting the variable CLMSV_SCALE_OUT_SCRIPT in clmd.conf
Start the cluster, and then start a node which isn't configured. The script
pointed to by CLMSV_SCALE_OUT_SCRIPT shall be called when this new node is
started. If the script adds IMM objects for the new node (e.g. by calling immcfg
-f), the new node shall be able to join the cluster.


Testing, Expected Results:
--------------------------
Script is called when an unconfigured node tries to join the cluster.


Conditions of Submission:
-------------------------
Ack from Mathi


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to