Summary: pyosaf: Add function to immom utils to get error strings [#1506] Review request for Trac Ticket(s): #1506 Peer Reviewer(s): [email protected], [email protected], [email protected], [email protected] Pull request to: [email protected] Affected branch(es): 4.7.x Development branch: opensaf-staging
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): --------------------------------------------- Add-on to the original patch for #1506 to make the solution usable without manually coding with ctypes. changeset 5cc42d7a1dd2b140505f4dc974ca9c192d460e74 Author: Johan Mårtensson <[email protected]> Date: Tue, 29 Sep 2015 13:48:05 +0200 pyosaf: Add function to immom utils to get error strings [#1506] Add convenience function to immom utils to get error strings without handling marshalling of ctypes. Complete diffstat: ------------------ python/pyosaf/utils/immom/__init__.py | 24 +++++++++++++++++++++++- 1 files changed, 23 insertions(+), 1 deletions(-) Testing Commands: ----------------- $ python/samples/caps & $ immcfg -c CapsSample capsId=1 $ python from pyosaf.utils.immom.ccb import Ccb ccb = Ccb() from pyosaf.utils import immom ccb.modify_value_replace('capsId=1', 'upperCaps', ['asdfsdf']) ccb.apply() print immom.get_error_strings(ccb.ccb_handle) Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
