Summary: amfd: reject si-swap if SI will remain with only active state (NWAY)[#1516]. Review request for Trac Ticket(s): #1516 Peer Reviewer(s): Hans N., Nagendra, Srikanth R. Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default and 4.7 Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset f9ae07397d93225f4841fa1b508d1d5b86ada021 Author: [email protected] Date: Tue, 13 Oct 2015 14:51:40 +0530 amfd: reject si-swap if SI will remain with only active state (NWAY)[#1516]. In the given configuration, swapped SI2 was fully assigned in the beginning but it had only one standby assignment. When SI-SWAP operation was performed on the SI, it caused removal of quiesced state after standby took the active role. In N-Way model a SI will have multiple standby assignments, so even if swap leads to removal of one standby there would be other standby SUs to take over the active role. So, I think, a general check for checking saAmfSGMaxStandbySIsperSU count for highest ranked SU is not needed and operation should be allowed if there are more than two standbys SUs exist for the SI and it will lead to removal of assignment after swap. A check can be added in a case where SI got reduced (by configuration or due to degraded state of the system) to 2N type of redundancy and operation will leave SI with only active state by removing the quiesced state. Patch rejects si-swap if there is only one standby assignment for SI and si- swap will lead to removal of quiesced assignment becuase of saAmfSGMaxStandbySIsperSU constraint. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) Testing Commands: ----------------- Perfromed SI-swap operation with following application: 3 SUs, 2 SIs, saAmfSGMaxStandbySIsperSU=1. After perorming si-swap operation successfuly multiple times on Si1 and Si2, a situation comes when si-swap will lead to removal of assignment and SI2 will have only standby assignment. In this siutation perform si-swap on SI2 Testing, Expected Results: -------------------------- Operation will be rejected with reason syslogged. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
