Hi Hung, Ack from me. Reviewed and tested the code.
Best regards, Zoran -----Original Message----- From: Hung Nguyen [mailto:[email protected]] Sent: Wednesday, October 14, 2015 11:03 AM To: Zoran Milinkovic; [email protected] Cc: [email protected] Subject: [PATCH 0 of 5] Review Request for imm: Add attribute def flag SA_IMM_ATTR_STRONG_DEFAULT [#1425] Summary: imm: Add attribute def flag SA_IMM_ATTR_STRONG_DEFAULT [#1425] Review request for Trac Ticket(s): 1425 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): default(5.0) Development branch: default(5.0) -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset abc9cb171cfaf6e7f215bdb165da2c2948bf9ffd Author: Hung Nguyen <[email protected]> Date: Sat, 10 Oct 2015 17:03:58 +0700 imm: Add OPENSAF_IMM_FLAG_PRT50_ALLOW value for noStdFlags [#1425] Add OPENSAF_IMM_FLAG_PRT50_ALLOW value for noStdFlags. changeset 97f68fdea8d8b35fa5e27622657602b2f18e5a2d Author: Hung Nguyen <[email protected]> Date: Sat, 10 Oct 2015 18:33:46 +0700 imm: Introduce SA_IMM_ATTR_STRONG_DEFAULT flag [#1425] SA_IMM_ATTR_STRONG_DEFAULT flag is supported in version A.02.17 or higher. changeset 039fff745e6598f92fe26274c34495622e0b8abf Author: Hung Nguyen <[email protected]> Date: Sat, 10 Oct 2015 21:13:43 +0700 imm: Support SA_IMM_ATTR_STRONG_DEFAULT flag [#1425] This flag is only allowed to be set on attributes that have a default value. Attributes with this flag will never be NULL. Adding this flag to an existing attribute (schema change) will be allowed after checking for ccb interference and existing objects of the class. When there's an attempt to set NULL value (or to delete all values with ATTR_VALUES_DELETE) to attributes with this flag, default value will be set. The AttrMod will be changed to ATTR_VALUES_REPLACE (attrValuesNumber = 1, attrValues is default value) and sent to OI. ImmAttrValue::operator= is used to assign value to ImmAttrValue. This will also work with ImmAttrMultiValue (head value will be assigned). changeset df95aae627587842db51a6cfec5ced9d838a4b3c Author: Hung Nguyen <[email protected]> Date: Sat, 10 Oct 2015 22:03:14 +0700 imm: Add support for strong default to IMM tools [#1425] Add support for strong default to IMM tools. changeset f014ddbdb1526c3551766d62de4bf562672a91d7 Author: Hung Nguyen <[email protected]> Date: Sat, 10 Oct 2015 22:21:46 +0700 imm: Add test cases for strong default [#1425] Add test cases for strong default. Added Files: ------------ osaf/libs/saf/include/saImmOm_A_2_17.h osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.17.xsd Complete diffstat: ------------------ opensaf.spec.in | 1 + osaf/libs/agents/saf/imma/imma_cb.h | 1 + osaf/libs/agents/saf/imma/imma_def.h | 2 +- osaf/libs/agents/saf/imma/imma_oi_api.c | 3 + osaf/libs/agents/saf/imma/imma_om_api.c | 18 +++++++++++ osaf/libs/common/immsv/immpbe_dump.cc | 3 +- osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +- osaf/libs/common/immsv/include/immsv_api.h | 1 + osaf/libs/saf/include/Makefile.am | 3 +- osaf/libs/saf/include/saImmOm_A_2_16.h | 2 + osaf/libs/saf/include/saImmOm_A_2_17.h | 67 ++++++++++++++++++++++++++++++++++++++++++ osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +++++- osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 2 +- osaf/services/saf/immsv/immnd/ImmModel.cc | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- osaf/services/saf/immsv/immnd/ImmModel.hh | 1 + osaf/services/saf/immsv/immnd/immnd_evt.c | 12 +++++++ osaf/services/saf/immsv/immnd/immnd_init.h | 1 + osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.17.xsd | 183 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/tools/safimm/immadm/imm_admin.c | 2 +- osaf/tools/safimm/immcfg/imm_cfg.c | 2 +- osaf/tools/safimm/immcfg/imm_import.cc | 7 +++- osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +++++ osaf/tools/safimm/immfind/imm_find.c | 2 +- osaf/tools/safimm/immlist/imm_list.c | 8 ++++- tests/immsv/common/immtest.c | 4 +- tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c | 6 +++ tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/immsv/management/test_saImmOmCcbInitialize.c | 6 +++ tests/immsv/management/test_saImmOmCcbObjectModify_2.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/immsv/management/test_saImmOmClassCreate_2.c | 107 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 30 files changed, 911 insertions(+), 17 deletions(-) Testing Commands: ----------------- Set NULL value to attributes with SA_IMM_ATTR_STRONG_DEFAULT flag. Testing, Expected Results: -------------------------- Default value is set. Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
