Summary: amfnd: terminate npi comp in non-restartable SU during admin SU
RESTART [#1561]
Review request for Trac Ticket(s): #1561
Peer Reviewer(s): Hans, Nagendra, Gary
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 4.7 and default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 0e556ca2c70a9279ea0b9e47bfb0c9e8ca153eb2
Author: Praveen
Date: Wed, 04 Nov 2015 11:35:45 +0530
amfnd: terminate npi comp in non-restartable SU during admin SU RESTART
#1561]
First user performs restart admin operation on SU. After this shutdown
operation is performed which left SG in unstable state.
Configuration used in the issue configures compinstantiationlevel for a
NPI
component and next instantiantionlevel belogns to a PI comp. Since a NPI
component is instantiated when it is assigned some work load. Issue is
reproducible when a configuration meets following criteria:
-Atleast one non-restartable component is present in the configuration.
-All non restartable component should be unassigned.
-NPI comp should be restartable.
-CompInstantiationlevel is configured in such a way that last
instantiationlevel belongs to a PI component which is non-restartable
and
unassigned.
When SU restart operation is invoked, AMFND picks the last component
which
is an unassigned non-restartable PI comp and starts terminaing it
(avnd_su_pres_inst_surestart_hdler). After successful termination, next
component is a NPI componenti.AMFND skips it and starts terminating
next PI
comp (avnd_su_pres_terming_compuninst_hdler). When SU moves to
Instantiated
state and AMF tries to reassgin SIs, SI assigned to NPI comp remains in
Assigning state as AMFND could not instantiate the component (it was not
terminated). After this when user tries shutdown operation on SU and
AMFND
sends quiescing state to AMFND, this assignment gets postponed as AMFND
waits infinitely for previous assignment because of surestart is still
pending.
Patch fixes the problem by terminating the NPI comp in a
non-restartable SU
during RESTART admin op on SU.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/comp.cc | 22 ++++++++++++++++++++++
osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 ++
osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 +
osaf/services/saf/amf/amfnd/su.cc | 9 +++++++++
osaf/services/saf/amf/amfnd/susm.cc | 17 +++++++++++++++++
5 files changed, 51 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Performed Restart admin operation on SU which consists of
restartable NPI comp and non-restartable PI comps. Both the
cases, when PI comps are assigned and unassigned, are tested.
After each restart, shutdown operation was invoked on the same su.
Testing, Expected Results:
--------------------------
restart and shutdown will be successful.
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
