Summary:cpsv: validated SaTimeT timeout argument value for all CPA APIs [#1583]
Review request for Trac Ticket(s): #1583
Peer Reviewer(s): Nagu/Ramesh
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default 4.7 4.6
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset d4aa5d28ba90896a847a926ed8e5033d98ba21fc
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Fri, 06 Nov 2015 10:58:10 +0530
cpsv: validated SaTimeT timeout argument value for all CPA APIs [#1583]
If
we test upper and lower limits of SaTimeT timeout arguments to CPSV API
,
some of CPA APIs are doesn't returns or hungs.
Current cpa code doesn't validating or passing SaTimeT timeout
arguments to
CPSV API , which are below default API timeout limit of CPSV_WAIT_TIME
(1400
X 10ms) and above SaTimeT, type long long int Maximum value
9223372036854775807 (2^63-1)
For example :
i) const SaTimeT timeout = 1215752192; ii) const SaTimeT timeout
= 2 * SA_TIME_ONE_MINUTE; iii) const SaTimeT timeout =
9223372036854775809;
saCkptCheckpointOpen(...., timeout, ...);
Because of that in some of variables are over flowing and , API calls
are
not working properly
Fix :
1 - Validated if (time_out < CPSV_WAIT_TIME) return
SA_AIS_ERR_INVALID_PARAM 2 - Validates if (expirationTime < 0 ) return
SA_AIS_ERR_INVALID_PARAM 3 - Pass proper timeout values to internal
functions of Opensaf
Complete diffstat:
------------------
osaf/libs/agents/saf/cpa/cpa_api.c | 111
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------
1 files changed, 91 insertions(+), 20 deletions(-)
Testing Commands:
-----------------
Do following test for the all CPA API by passing below values which has
SaTimeT timeout argument.
1 - Validated if (time_out < CPSV_WAIT_TIME) return SA_AIS_ERR_INVALID_PARAM
2 - Validates if (expirationTime < 0 ) return SA_AIS_ERR_INVALID_PARAM
3 - Pass proper timeout values to internal functions of Opensaf
Testing, Expected Results:
--------------------------
All APIs should pass
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
