Hi Long, patch is now pushed/Thanks HansN On 11/12/2015 01:29 PM, Long Nguyen wrote: > Hi Hans, > > You and Praveen ack'ed for this series. Can you please help to push > the code to the repository? I have zip'ed the patches for AMFD in the > attachment. > Because many files have been changed, it would be good if you can push > it before someone else apply their patches. Thanks so much. > > Best regards, > Long Nguyen. > > On 10/27/2015 7:08 PM, Hans Nordebäck wrote: >> Ack for the series, code review only/Thanks HansN >> >> -----Original Message----- >> From: Long Buu Nguyen H >> Sent: den 19 oktober 2015 13:18 >> To: Hans Nordebäck; Gary Lee; [email protected]; >> [email protected] >> Cc: [email protected] >> Subject: [PATCH 00 of 48] Review Request for amfd: convert NULL to >> nullptr V2 [#1547] >> >> Summary: amfd: convert NULL to nullptr V2 [#1547] Review request for >> Trac Ticket(s): [#1547] Peer Reviewer(s): Hans, Gary, Praveen, Nagu >> Pull request to: Hans Affected branch(es): default Development >> branch: default >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> In this Version 2: >> >> changeset c5187539b22b3ece04e72f68c1e5430d06d088d2 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for app.cc [#1547] >> >> changeset 046710d2e6e739b67c317d01350c6a5566fda3fa >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for apptype.cc [#1547] >> >> changeset 58e81ef6a0e7af8edb4dbced7325180d11d8d291 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for chkop.cc [#1547] >> >> changeset 555a485e21501fbfce91cc15d0ebd6833aed93d2 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for ckpt_dec.cc [#1547] >> >> changeset 1e8ebe3388af55e1d64c3ab56193f30965d1faa1 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for ckpt_edu.cc [#1547] >> >> changeset db7407ddfe2234a3e0e287ebb9ee0d7a8f9d17aa >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for ckpt_enc.cc [#1547] >> >> changeset c41b2a3d0081450ceddae17aadb2632046d35d74 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for ckpt_updt.cc [#1547] >> >> changeset fa79edb33b37c99282c7fb2f94a4f96224f558fa >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for clm.cc [#1547] >> >> changeset dcc4bb199d8af85845a7e3b64863c856c869d617 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for cluster.cc [#1547] >> >> changeset beb1263225472b3c0910a7a2c1530cd82fb5146e >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for comp.cc [#1547] >> >> changeset 3e80fd0be4fe99f86d4164a16e85ee2e813dd011 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for compcstype.cc [#1547] >> >> changeset 825d548b07e2f475206087e4894f3614a2ae7ce7 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for comptype.cc [#1547] >> >> changeset 50ab0756779cd98485e888ecbeb7afad622b5f00 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for csi.cc [#1547] >> >> changeset 1dc8d75ec1908ff1ca3a425940dfa74022c6be86 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for csiattr.cc [#1547] >> >> changeset 5d7b22e83a1dc2bbb6d6ab635aff96d1d6e92b2a >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for cstype.cc [#1547] >> >> changeset 6851f9b8b07b46ab5a5921baca0f95810956645c >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for ctcstype.cc [#1547] >> >> changeset 6cc6ad0b98a3c5d6fa75636ffcb866284f53c214 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for dmsg.cc [#1547] >> >> changeset 6a0ad0242288a50b6436cc277a96bf097959245d >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for hlt.cc [#1547] >> >> changeset 16756ef5d2059e96ed3900bc7d91e20b592b65ed >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for hlttype.cc [#1547] >> >> changeset 35732c793eeb21ebb69f5e4ca3531e8243861dc0 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for imm.cc [#1547] >> >> changeset af5745cae6be58404d8aeba6b29732d866c27f74 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:29 +0700 >> >> amfd: convert NULL to nullptr for main.cc [#1547] >> >> changeset 3027dc07b89f0d161f877efb9ff6adb4e2852b5c >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for ndfsm.cc [#1547] >> >> changeset 4799e0de61cf2aea249e2c77622c30501d47f1ae >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for ndmsg.cc [#1547] >> >> changeset 959497b6aa52e2d60d1f887a475fa6f699b28b6c >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for ndproc.cc [#1547] >> >> changeset 8da3f319857175726b4c6637222a0a91d793ef97 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for node.cc [#1547] >> >> changeset 42dfdbac197ee6a824ae1ef29abd0f9611802975 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for nodegroup.cc [#1547] >> >> changeset 76f52dad1496df8efdac8d07d68e88c23f88866c >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for nodeswbundle.cc [#1547] >> >> changeset 3029a8d3015cd606a5b80e172cfdfaf4c4d0c12f >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for ntf.cc [#1547] >> >> changeset 840b35be3a9cce8a8b82f96c83850ad634897022 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for pg.cc [#1547] >> >> changeset 75b241bd8dc5226aea064e59e142feadb0eccb0d >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for role.cc [#1547] >> >> changeset 7051a67f4150997429cd86e46f0bb3d053c56110 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sg.cc [#1547] >> >> changeset 8018fb2a5315638e0cf1808f4ad0ee717dde4171 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sg_2n_fsm.cc [#1547] >> >> changeset fbc28b6f6ab4a4b56fae5122e323a48907257e51 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sg_nored_fsm.cc [#1547] >> >> changeset fa39546215fab9bc3085484261a4a7a7c641ac8a >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sg_npm_fsm.cc [#1547] >> >> changeset ed90bc8e535eb807a7b5faa3233ff67bb614cad4 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sg_nway_fsm.cc [#1547] >> >> changeset 6f4c55d866b637b664af87e2341aa5e2ffe849d6 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sg_nwayact_fsm.cc [#1547] >> >> changeset 34698eb08ef9603071c97c963775c1b99b15d852 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sgproc.cc [#1547] >> >> changeset 3c60a8d966615f5fe51cd0153716fe3e6e4a265f >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sgtype.cc [#1547] >> >> changeset 1e31627d42209e8dd26bac83c1c0bf1d98f866a9 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for si.cc [#1547] >> >> changeset 04dec3f8b39516fd21c3f0c9e0352cea386aa2e9 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for si_dep.cc [#1547] >> >> changeset a7a565d9fb40e6c7b5a7562bd0f0020c4d182329 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for siass.cc [#1547] >> >> changeset 72ac49a8fe692e659c7777d7e124dd0eb90093a6 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sirankedsu.cc [#1547] >> >> changeset 489c7e4ba6c5a49987a0d0a135388710295c11f7 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for su.cc [#1547] >> >> changeset 6e66b4247fe16f6c6d243af6744cc4e08c06dc4a >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sutcomptype.cc [#1547] >> >> changeset d474727765f395853f8ec4cdb6f552ae987ab795 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for sutype [#1547] >> >> changeset 14e23ce37f456db912f739a69347aeaafc7de048 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for svctype.cc [#1547] >> >> long_description >> >> changeset 5ecb1d2f5f55d813ebf79e20ec1b971f697e99b3 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for svctypecstypes.cc [#1547] >> >> changeset 62eb2da4d09c18fa67e6206966448242ef09c1b4 >> Author: Long HB Nguyen<[email protected]> >> Date: Mon, 19 Oct 2015 15:37:30 +0700 >> >> amfd: convert NULL to nullptr for util.cc [#1547] >> >> >> Complete diffstat: >> ------------------ >> osaf/services/saf/amf/amfd/app.cc | 84 >> +++++++++++++++++++++++++++--------------------------- >> osaf/services/saf/amf/amfd/apptype.cc | 52 >> +++++++++++++++++----------------- >> osaf/services/saf/amf/amfd/chkop.cc | 16 +++++----- >> osaf/services/saf/amf/amfd/ckpt_dec.cc | 84 >> +++++++++++++++++++++++++++--------------------------- >> osaf/services/saf/amf/amfd/ckpt_edu.cc | 182 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------ >> osaf/services/saf/amf/amfd/ckpt_enc.cc | 14 ++++---- >> osaf/services/saf/amf/amfd/ckpt_updt.cc | 74 >> ++++++++++++++++++++++++------------------------ >> osaf/services/saf/amf/amfd/clm.cc | 20 ++++++------ >> osaf/services/saf/amf/amfd/cluster.cc | 14 ++++---- >> osaf/services/saf/amf/amfd/comp.cc | 118 >> +++++++++++++++++++++++++++++++++++++++--------------------------------------- >> osaf/services/saf/amf/amfd/compcstype.cc | 44 >> ++++++++++++++-------------- >> osaf/services/saf/amf/amfd/comptype.cc | 92 >> ++++++++++++++++++++++++++++++------------------------------ >> osaf/services/saf/amf/amfd/csi.cc | 180 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------- >> osaf/services/saf/amf/amfd/csiattr.cc | 62 >> ++++++++++++++++++++-------------------- >> osaf/services/saf/amf/amfd/cstype.cc | 42 >> +++++++++++++------------- >> osaf/services/saf/amf/amfd/ctcstype.cc | 28 +++++++++--------- >> osaf/services/saf/amf/amfd/dmsg.cc | 4 +- >> osaf/services/saf/amf/amfd/hlt.cc | 8 ++-- >> osaf/services/saf/amf/amfd/hlttype.cc | 8 ++-- >> osaf/services/saf/amf/amfd/imm.cc | 110 >> ++++++++++++++++++++++++++++++++++++------------------------------------ >> osaf/services/saf/amf/amfd/main.cc | 30 +++++++++--------- >> osaf/services/saf/amf/amfd/ndfsm.cc | 36 >> +++++++++++----------- >> osaf/services/saf/amf/amfd/ndmsg.cc | 12 +++--- >> osaf/services/saf/amf/amfd/ndproc.cc | 62 >> ++++++++++++++++++++-------------------- >> osaf/services/saf/amf/amfd/node.cc | 94 >> +++++++++++++++++++++++++++++++------------------------------- >> osaf/services/saf/amf/amfd/nodegroup.cc | 88 >> +++++++++++++++++++++++++++++----------------------------- >> osaf/services/saf/amf/amfd/nodeswbundle.cc | 4 +- >> osaf/services/saf/amf/amfd/ntf.cc | 18 +++++----- >> osaf/services/saf/amf/amfd/pg.cc | 6 +- >> osaf/services/saf/amf/amfd/role.cc | 36 >> +++++++++++----------- >> osaf/services/saf/amf/amfd/sg.cc | 162 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------- >> osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 248 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------------- >> osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 46 >> +++++++++++++++--------------- >> osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 272 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------------------ >> osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 188 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------- >> osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 176 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------- >> osaf/services/saf/amf/amfd/sgproc.cc | 104 >> ++++++++++++++++++++++++++++++++++---------------------------------- >> osaf/services/saf/amf/amfd/sgtype.cc | 42 >> +++++++++++++------------- >> osaf/services/saf/amf/amfd/si.cc | 182 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------ >> osaf/services/saf/amf/amfd/si_dep.cc | 224 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------- >> osaf/services/saf/amf/amfd/siass.cc | 72 >> +++++++++++++++++++++++----------------------- >> osaf/services/saf/amf/amfd/sirankedsu.cc | 68 >> ++++++++++++++++++++++---------------------- >> osaf/services/saf/amf/amfd/su.cc | 206 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------- >> osaf/services/saf/amf/amfd/sutcomptype.cc | 16 +++++----- >> osaf/services/saf/amf/amfd/sutype.cc | 42 >> +++++++++++++------------- >> osaf/services/saf/amf/amfd/svctype.cc | 38 >> ++++++++++++------------ >> osaf/services/saf/amf/amfd/svctypecstypes.cc | 20 ++++++------ >> osaf/services/saf/amf/amfd/util.cc | 64 >> +++++++++++++++++++++--------------------- >> 48 files changed, 1896 insertions(+), 1896 deletions(-) >> >> >> Testing Commands: >> ----------------- >> Run AmfDemo (2N, NWay-Active) >> >> >> Testing, Expected Results: >> -------------------------- >> AmfDemo runs without errors >> >> >> Conditions of Submission: >> ------------------------- >> <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 y y >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank >> entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your >> headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be >> pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear >> indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial >> review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> >> >
------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
