Hi Vu

Ack.

Have tested by setting hard coded default to 63 and set the environment 
variable to 65 and removing default value from class definition
Used the runtime configuration object to see actual configuration.

Without patch :
- Value = 63, meaning that the default value was incorrectly used instead of 
the environment variable

With patch:
- Value = 65, is correct, environment variable is used
- Added 64 as default value in the class definition and got value 64 which is 
correct

Thanks
Lennart


> -----Original Message-----
> From: Vu Minh Nguyen [mailto:[email protected]]
> Sent: den 17 november 2015 07:25
> To: [email protected]; Lennart Lund; Giang Do T
> Cc: [email protected]
> Subject: [PATCH 1 of 1] log: wong condition check that might cause
> incorrectly configured log service [#1596]
> 
>  osaf/services/saf/logsv/lgs/lgs_config.c |  2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> Fix wrong condition checking for `logMaxApplicationStreams` that might
> cause
> incorrect configured log service at startup.
> 
> diff --git a/osaf/services/saf/logsv/lgs/lgs_config.c
> b/osaf/services/saf/logsv/lgs/lgs_config.c
> --- a/osaf/services/saf/logsv/lgs/lgs_config.c
> +++ b/osaf/services/saf/logsv/lgs/lgs_config.c
> @@ -1088,7 +1088,7 @@ static void read_log_config_environ_var_
>       /* logMaxApplicationStreams
>        * Rule: Object has precedence
>        */
> -     if (lgs_conf.logMaxLogrecsize_cnfflag == LGS_CNF_DEF) {
> +     if (lgs_conf.logMaxApplicationStreams_cnfflag ==
> LGS_CNF_DEF) {
>               if ((val_str =
> getenv("LOG_MAX_APPLICATION_STREAMS")) != NULL) {
>                       errno = 0;
>                       val_uint = strtoul(val_str, NULL,
> 0);

------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to