Summary: amfnd: node director fails to restart immnd if immnds CompType is changed [#1602] Review request for Trac Ticket(s): 1602 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): 4.6, 4.7, default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 04f927873d19c3876382c04d84a31bea1b6e632f Author: Gary Lee<[email protected]> Date: Wed, 18 Nov 2015 14:31:41 +1100 amfnd: skip config reload if CompType has not changed [#1602] An upgrade campaign may 'change' saAmfCompType of IMMND to the same version, forcing comp->config_is_valid to be set to 0. If the nodes are not rebooted as part of the campaign, and immnd is later restarted for whatever reason, the restart will fail as amfnd is trying to refresh immnd's config when immnd is down. If no version change actually occurs, we don't need to touch config_is_valid. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/compdb.cc | 15 +++++++++++---- osaf/services/saf/amf/amfnd/include/avnd_util.h | 7 +++++++ 2 files changed, 18 insertions(+), 4 deletions(-) Testing Commands: ----------------- immcfg -a saAmfCompType="safVersion=4.0.0,safCompType=OpenSafCompTypeIMMND" safComp=IMMND,safSu=PL-3,safSg=NoRed,safApp=OpenSAF kill immnd on PL-3 Testing, Expected Results: -------------------------- immnd on PL-3 restarts Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
