Ack, code review only. Thanks, Praveen
On 23-Nov-15 11:38 AM, [email protected] wrote: > osaf/services/saf/amf/amfd/chkop.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > When cold sync req reaches Act Amfd and when its state is in AVD_CFG_DONE, > it returns NCSCC_RC_FAILURE to Mbcsv. Mbcsv doesn't respond back to > its Standby peer that Cold sync has failed. Act Mbcsv peer waits till > Cold sync timer NCS_MBCSV_TMR_SEND_COLD_SYNC_PERIOD (9 Secs). > After this timer expires, Standby Mbcsv peer resends the request, this > time Act Amfd is in AVD_INIT_DONE and hence Cold sync starts. > This is the reason for 9 Seconds delay reported in the ticket. > > Amfd can start Cold sync even it has read the configuration > and it need not wait the Act controller to come up fully. > That means, Amfd need not wait till m/w susi is assigned on > Act controller. Because, for Standby SUSI to get assigned, > Amfd should be in AVD_INIT_DONE, so this avoids, Standby Controller > taking Act role (2N M/w susi). > So, the fix paces up Cold sync to start. > > diff --git a/osaf/services/saf/amf/amfd/chkop.cc > b/osaf/services/saf/amf/amfd/chkop.cc > --- a/osaf/services/saf/amf/amfd/chkop.cc > +++ b/osaf/services/saf/amf/amfd/chkop.cc > @@ -405,7 +405,7 @@ ignore_msg: > */ > TRACE("COLD_SYNC_REQ"); > > - if (cb->init_state < AVD_INIT_DONE) { > + if (cb->init_state < AVD_CFG_DONE) { > TRACE("invalid init state (%u) for cold sync > req", cb->init_state); > status = NCSCC_RC_FAILURE; > } > ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
