Hi, ACK from me .
It looks patch covered the previous comments are addressed , now we can push this patch ( not tested ) subsequent while usage if we find any small things missing we can fix them as Bug later , so please go a head and push it . -AVM On 11/23/2015 8:44 AM, Nhat Pham wrote: > Hi, > > Could you please have a look at this patch? Thanks. > > Best regards, > Nhat Pham > > -----Original Message----- > From: Nhat Pham [mailto:[email protected]] > Sent: Monday, November 16, 2015 11:20 AM > To: [email protected]; [email protected] > Cc: [email protected] > Subject: [devel] [PATCH 0 of 1] Review Request for ckpt: cpsv tests > improvement [#1481] v3 > > Summary: ckpt: cpsv tests improvement > Review request for Trac Ticket(s): 1481 > Peer Reviewer(s): [email protected]; [email protected] Pull > request to: [email protected] Affected branch(es): default Development > branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests y > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset f67165cd4720b24c4343b17692f1409cd936794f > Author: Nhat Pham <[email protected]> > Date: Mon, 16 Nov 2015 11:12:57 +0700 > > ckpt: cpsv tests improvement [#1481] > > To make cpsv tests working again and independent from tetware. > > > Added Files: > ------------ > tests/cpsv/cpsvtest.c > tests/cpsv/Makefile.am > tests/cpsv/README > tests/cpsv/test_cpa.c > tests/cpsv/test_cpa_util.c > tests/cpsv/test_cpsv_conf.h > tests/cpsv/test_cpsv.h > > > Removed Files: > -------------- > tests/cpsv/inc/tet_cpsv_conf.h > tests/cpsv/inc/tet_cpsv.h > tests/cpsv/Makefile > tests/cpsv/src/tet_cpa.c > tests/cpsv/src/tet_cpa_test.c > tests/cpsv/src/tet_cpd.c > tests/cpsv/src/tet_cpnd.c > tests/cpsv/src/tet_cpsv_util.c > tests/cpsv/suites/cpsv_env.sh > tests/cpsv/suites/reg_cpsv.cfg > tests/cpsv/suites/reg_cpsv.dep > tests/cpsv/suites/reg_cpsv.scen > > > Complete diffstat: > ------------------ > Makefile.am | 1 + > configure.ac | 1 + > opensaf.spec.in | 1 + > osaf/libs/agents/saf/cpa/cpa_init.c | 1 - > tests/cpsv/Makefile | 48 - > tests/cpsv/Makefile.am | 44 + > tests/cpsv/README | 63 + > tests/cpsv/cpsvtest.c | 54 + > tests/cpsv/inc/tet_cpsv.h | 988 ------------------------- > tests/cpsv/inc/tet_cpsv_conf.h | 182 ---- > tests/cpsv/src/tet_cpa.c | 2325 > ------------------------------------------------------------ > tests/cpsv/src/tet_cpa_test.c | 7179 > ---------------------------------------------------------------------------- > ---------------------------------------------------------------------------- > ---------------------------------- > tests/cpsv/src/tet_cpd.c | 98 -- > tests/cpsv/src/tet_cpnd.c | 101 -- > tests/cpsv/src/tet_cpsv_util.c | 659 ----------------- > tests/cpsv/suites/cpsv_env.sh | 17 - > tests/cpsv/suites/reg_cpsv.cfg | 4 - > tests/cpsv/suites/reg_cpsv.dep | 6 - > tests/cpsv/suites/reg_cpsv.scen | 2 - > tests/cpsv/test_cpa.c | 7009 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++ > tests/cpsv/test_cpa_util.c | 2161 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/cpsv/test_cpsv.h | 967 +++++++++++++++++++++++++ > tests/cpsv/test_cpsv_conf.h | 183 ++++ > 23 files changed, 10484 insertions(+), 11610 deletions(-) > > > Testing Commands: > ----------------- > cpsv_test > > > Testing, Expected Results: > -------------------------- > All test cases should pass. > > > Conditions of Submission: > ------------------------- > - > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ---------------------------------------------------------------------------- > -- > Presto, an open source distributed SQL query engine for big data, initially > developed by Facebook, enables you to easily query your data on Hadoop in a > more interactive manner. Teradata is also now providing full enterprise > support for Presto. Download a free open source copy now. > http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140 > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > > ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
