Summary: amfd: use simple decode/encode for AVD_CL_CB [#1544] Review request for Trac Ticket(s): 1544 Peer Reviewer(s): Hans, Nagu, Praveen Pull request to: as above Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Note: must be applied on top of Han's previous patches for simple decode/encode of AVD_COMP. changeset c7c987f0f495fa9552b562a9422d8066f139f751 Author: Gary Lee<[email protected]> Date: Wed, 25 Nov 2015 17:28:06 +1100 amfd: use simple decode/encode for AVD_CL_CB [#1544] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/ckpt_dec.cc | 51 ++++++++++++++++++++------------------------------- osaf/services/saf/amf/amfd/ckpt_edu.cc | 54 ------------------------------------------------------ osaf/services/saf/amf/amfd/ckpt_enc.cc | 38 ++++++++++++++++---------------------- osaf/services/saf/amf/amfd/include/ckpt.h | 2 ++ osaf/services/saf/amf/amfd/include/ckpt_edu.h | 3 --- osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 98 insertions(+), 110 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
