ack, code review only/Thanks HansN

On 11/18/2015 06:41 AM, [email protected] wrote:
>   osaf/services/saf/amf/amfd/si.cc |  7 ++++---
>   1 files changed, 4 insertions(+), 3 deletions(-)
>
>
> AMFD asserts for following CCB modification:
> immcfg -a saAmfSIPrefActiveAssignments= safSi=All-NWayActive,safApp=DemoApp
>
> When AMFD gets CCB apply callback, it is setting saAmfSIPrefActiveAssignments 
> to its
> default value 1 before adjusting assignments.
>
> Patch fixes the problem by setting saAmfSIPrefActiveAssignments only after
> adjusting assignments.
>
> diff --git a/osaf/services/saf/amf/amfd/si.cc 
> b/osaf/services/saf/amf/amfd/si.cc
> --- a/osaf/services/saf/amf/amfd/si.cc
> +++ b/osaf/services/saf/amf/amfd/si.cc
> @@ -1145,10 +1145,11 @@ static void si_ccb_apply_modify_hdlr(Ccb
>   
>               if (!strcmp(attribute->attrName, 
> "saAmfSIPrefActiveAssignments")) {
>   
> -                     if (value_is_deleted)
> -                             mod_pref_assignments = 
> si->saAmfSIPrefActiveAssignments = 1;
> -                     else
> +                     if (value_is_deleted) {
> +                             mod_pref_assignments = 1;
> +                     } else {
>                               mod_pref_assignments = *((SaUint32T 
> *)attr_mod->modAttr.attrValues[0]);
> +                     }
>   
>                       if (avd_cb->avail_state_avd != SA_AMF_HA_ACTIVE) {
>                               si->saAmfSIPrefActiveAssignments = 
> mod_pref_assignments;


------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to