Summary: cpsv: cpd broadcasts CPND_EVT_D2ND_CKPT_RDSET with STOP [#1615] Review request for Trac Ticket(s): 1615 Peer Reviewer(s): [email protected]; [email protected] Pull request to: [email protected] Affected branch(es): 4.6, 4.7, default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 7ccd597858cc8d55daf3fd99576eaf36ec723b80 Author: Nhat Pham <[email protected]> Date: Tue, 01 Dec 2015 13:47:41 +0700 cpsv: cpd broadcasts CPND_EVT_D2ND_CKPT_RDSET with STOP [#1615] Problem: -------- A non-collocated checkpoint is firstly created on SC-2. Then the checkpoint is closed on SC-2. The CPD broadcasts CPND_EVT_D2ND_CKPT_RDSET with START to start retention duration timer on CPND because there is no user. During that time the checkpoint is opened again and using on PL-3. After retention duration, the checkpoint is destroyed on both SC-1 and SC-2. Solution: --------- The problem happens because the CPD doesn't broadcasts CPND_EVT_D2ND_CKPT_RDSET with STOP when the checkpoint is opened again on PL-3. The CPD is updated to broadcasts CPND_EVT_D2ND_CKPT_RDSET with STOP when the checkpoint is opened again. Complete diffstat: ------------------ osaf/libs/common/cpsv/include/cpd_proc.h | 2 ++ osaf/services/saf/cpsv/cpd/cpd_evt.c | 8 +++++++- osaf/services/saf/cpsv/cpd/cpd_proc.c | 22 ++++++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletions(-) Testing Commands: ----------------- Follow testing steps in the ticket 1615. Testing, Expected Results: -------------------------- The checkpoint should still remain after retention duration. Conditions of Submission: ------------------------- - Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
