Summary: log: switching to use the C++ compiler [#1624] Review request for Trac Ticket(s): #1624 Peer Reviewer(s): [email protected]; [email protected]; [email protected] Pull request to: Lennart Affected branch(es): Default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset e59bd481b8c26a827ef023ea1abd7e0201bf2c64 Author: Vu Minh Nguyen <[email protected]> Date: Tue, 08 Dec 2015 09:24:12 +0700 log: switching to use the C++ compiler [#1624] Fix error messages when using C++ compiler Complete diffstat: ------------------ osaf/services/saf/logsv/lgs/Makefile.am | 34 +++++++------ osaf/services/saf/logsv/lgs/lgs.h | 18 ++++++- osaf/services/saf/logsv/lgs/lgs_amf.c | 33 +------------ osaf/services/saf/logsv/lgs/lgs_cb.h | 8 +++ osaf/services/saf/logsv/lgs/lgs_config.c | 172 +++++++++++++++++++++++++++---------------------------------------------- osaf/services/saf/logsv/lgs/lgs_config.h | 2 +- osaf/services/saf/logsv/lgs/lgs_evt.c | 22 +++++---- osaf/services/saf/logsv/lgs/lgs_evt.h | 9 +++ osaf/services/saf/logsv/lgs/lgs_file.c | 45 +++++++++++-------- osaf/services/saf/logsv/lgs/lgs_filehdl.c | 22 +++++--- osaf/services/saf/logsv/lgs/lgs_fmt.c | 26 ++++++----- osaf/services/saf/logsv/lgs/lgs_fmt.h | 8 +++ osaf/services/saf/logsv/lgs/lgs_imm.c | 339 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------- osaf/services/saf/logsv/lgs/lgs_main.c | 101 +++++++++---------------------------------- osaf/services/saf/logsv/lgs/lgs_mbcsv.c | 123 +++++++++++++++++++++++++++------------------------- osaf/services/saf/logsv/lgs/lgs_mbcsv.h | 2 +- osaf/services/saf/logsv/lgs/lgs_mbcsv_v1.c | 28 ++++++------ osaf/services/saf/logsv/lgs/lgs_mbcsv_v1.h | 6 +- osaf/services/saf/logsv/lgs/lgs_mbcsv_v2.c | 34 +++++++------- osaf/services/saf/logsv/lgs/lgs_mbcsv_v3.c | 26 +++++----- osaf/services/saf/logsv/lgs/lgs_mbcsv_v5.c | 26 +++++----- osaf/services/saf/logsv/lgs/lgs_mds.c | 40 +++++++++------- osaf/services/saf/logsv/lgs/lgs_stream.c | 64 ++++++++++++++------------- osaf/services/saf/logsv/lgs/lgs_stream.h | 8 +++ osaf/services/saf/logsv/lgs/lgs_util.c | 36 +++++++++------ osaf/services/saf/logsv/lgs/lgs_util.h | 9 +++ 26 files changed, 624 insertions(+), 617 deletions(-) Testing Commands: ----------------- The changes do not change or have any impact on current LOG functionalities. To test this, build it then run the LOG test suite logtest. NOTE: 1) The patch has to apply on top of #1527, otherwise the apply gets failed. 2) There is an error message in an common header file when building with C++ compiler. Here is the file and error message: In file included from lgs_config.cc:35:0: ../../../../../osaf/libs/core/common/include/osaf_secutil.h:21:0: error: "_GNU_SOURCE" redefined [-Werror] #define _GNU_SOURCE I does a workaround by modifying osaf_secutil.h like this (add #ifndef checking): #ifndef __GNU_SOURCE #define _GNU_SOURCE #endif Testing, Expected Results: -------------------------- All tests PASS Conditions of Submission: ------------------------- Get ack from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
