Summary: amfnd: Remove mbcsv code from amfnd [#1637] Review request for Trac Ticket(s): #1637 Peer Reviewer(s): Hans, Praveen, Nagu, Gary Pull request to: Hans Nordeback Affected branch(es): default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services Y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 897e30e89d01d08f44e88ce5ed9d279340d1126f Author: Quyen Dao <[email protected]> Date: Tue, 15 Dec 2015 11:45:04 +0700 amfnd: Remove mbcsv code from amfnd [#1637] 1. Remove mbcsv related code 2. Move the marco/functions not related to mbcsv (but reside in the mbcsv related files) to other better places. * Move m_AVND_CHECK_FOR_STDBY_FOR_EXT_COMP from avnd_mbcsv.h to avnd_comp.h * Move m_AVND_SU_SI_CSI_REC_REM from avnd_ckpt_updt.h to avnd_su.h * Move avnd_evt_ha_state_change_evh from mbcsv.cc to evt.cc and remove the mbcsv related part * Move avnd_evt_avd_role_change_evh from mbcsv.cc to di.cc and remove the mbcsv related part Removed Files: -------------- osaf/services/saf/amf/amfnd/ckpt_dec.cc osaf/services/saf/amf/amfnd/ckpt_edu.cc osaf/services/saf/amf/amfnd/ckpt_enc.cc osaf/services/saf/amf/amfnd/ckpt_updt.cc osaf/services/saf/amf/amfnd/include/avnd_ckpt_edu.h osaf/services/saf/amf/amfnd/include/avnd_ckpt_msg.h osaf/services/saf/amf/amfnd/include/avnd_ckpt_updt.h osaf/services/saf/amf/amfnd/include/avnd_mbcsv.h osaf/services/saf/amf/amfnd/mbcsv.cc Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/Makefile.am | 5 - osaf/services/saf/amf/amfnd/amfnd.cc | 6 - osaf/services/saf/amf/amfnd/cbq.cc | 12 - osaf/services/saf/amf/amfnd/chc.cc | 67 -- osaf/services/saf/amf/amfnd/ckpt_dec.cc | 4509 ---------------------------------------------------------------------------------------------------------------------------------------------- osaf/services/saf/amf/amfnd/ckpt_edu.cc | 705 ---------------------- osaf/services/saf/amf/amfnd/ckpt_enc.cc | 3679 ------------------------------------------------------------------------------------------------------------------- osaf/services/saf/amf/amfnd/ckpt_updt.cc | 1090 ---------------------------------- osaf/services/saf/amf/amfnd/clc.cc | 95 +-- osaf/services/saf/amf/amfnd/clm.cc | 3 - osaf/services/saf/amf/amfnd/comp.cc | 77 -- osaf/services/saf/amf/amfnd/compdb.cc | 29 +- osaf/services/saf/amf/amfnd/di.cc | 76 ++- osaf/services/saf/amf/amfnd/err.cc | 45 +- osaf/services/saf/amf/amfnd/evt.cc | 42 + osaf/services/saf/amf/amfnd/hcdb.cc | 4 - osaf/services/saf/amf/amfnd/include/Makefile.am | 4 - osaf/services/saf/amf/amfnd/include/avnd.h | 4 - osaf/services/saf/amf/amfnd/include/avnd_cb.h | 23 +- osaf/services/saf/amf/amfnd/include/avnd_ckpt_edu.h | 65 -- osaf/services/saf/amf/amfnd/include/avnd_ckpt_msg.h | 173 ----- osaf/services/saf/amf/amfnd/include/avnd_ckpt_updt.h | 51 - osaf/services/saf/amf/amfnd/include/avnd_comp.h | 10 +- osaf/services/saf/amf/amfnd/include/avnd_mbcsv.h | 119 --- osaf/services/saf/amf/amfnd/include/avnd_su.h | 9 +- osaf/services/saf/amf/amfnd/main.cc | 32 - osaf/services/saf/amf/amfnd/mbcsv.cc | 1681 ---------------------------------------------------- osaf/services/saf/amf/amfnd/mds.cc | 64 -- osaf/services/saf/amf/amfnd/proxy.cc | 1 - osaf/services/saf/amf/amfnd/proxydb.cc | 1 - osaf/services/saf/amf/amfnd/sidb.cc | 56 - osaf/services/saf/amf/amfnd/su.cc | 22 +- osaf/services/saf/amf/amfnd/sudb.cc | 2 - osaf/services/saf/amf/amfnd/susm.cc | 95 +-- 34 files changed, 132 insertions(+), 12724 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
