Thanks, Zoran. I will fix that.
I forgot that there is at most one OI, so no need to check if
canonicalizedAttrMod is already generated.
BR,
Hung Nguyen - DEK Technologies
--------------------------------------------------------------------------------
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Tuesday, December 15, 2015 9:00PM
To: Hung Nguyen, Neelakanta Reddy
hung.d.ngu...@dektech.com.au, reddy.neelaka...@oracle.com
Cc: Opensaf-devel
opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] imm: Canonicalize attributes presented by
OiCcbObjectModifyCallback [#801]
Hi Hung,
Reviewed and tested.
Ack with one minor comment.
Best regards,
Zoran
@@ -6317,6 +6329,19 @@ static void immnd_evt_proc_object_modify
IMMA_EVT_ND2A_OI_OBJ_MODIFY_LONG_UC :
IMMA_EVT_ND2A_OI_OBJ_MODIFY_UC;
send_evt.info.imma.info.objModify =
evt->info.objModify;
+
+ /* For A.2.17 or later */
+ if (oi_cl_node->version.minorVersion >= 0x11 &&
+
oi_cl_node->version.majorVersion == 0x2 &&
+ oi_cl_node->version.releaseCode
== 'A') {
+ if (!canonicalizedAttrMod) {
[Zoran] canonicalizedAttrMod is initially set to NULL. There is no need for
extra check if canonicalizedAttrMod is NULL or not.
+ canonicalizedAttrMod =
+
immModel_canonicalizeAttrModification(cb, &(evt->info.objModify),
+
false, NULL);
+ }
+
send_evt.info.imma.info.objModify.attrMods = canonicalizedAttrMod;
+ }
+
/* shallow copy into stack alocated structure.
*/
send_evt.info.imma.info.objModify.adminOwnerId
= continuationId;
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
