Hi Anders,

Anders Widell had made this change. He knows better why the default 
value has been changed.
This is from cloud repository (CoreMw_Upgrade_3.6.xml is 
OpensafImm_Upgrade_5.0.xml now)

changeset:   7420:8d967dfa8892
branch:      cloud
parent:      7416:d7fafdcdcdc8
user:        Anders Widell <anders.wid...@ericsson.com>
date:        Sun Nov 22 17:59:52 2015 +0100
files:       samples/immsv/CoreMw_Upgrade_3.6.xml
description:
Changed default value for longDnsAllowed artf648658

BR,
Zoran

On 12/23/2015 11:36 AM, Anders Bjornerstedt wrote:
> Hi Zoran,
>
> Why is the default for longDnsAllowed changed ?
> This is obviously not a backwards compatible change.
>
> Have all OpenSAF services been converted to support long DNs ?
> Applications out there that dont support long DNs will now have to be aware 
> of this change and will have to expplicitly
> set this config attribute to false. Remember this is supposed to be 
> open-source.
>
> /AndersBj
>
>
>
>> ----Ursprungligt meddelande----
>> Från : zoran.milinko...@ericsson.com
>> Datum : 23-12-2015 - 09:49 (GMT)
>> Till : reddy.neelaka...@oracle.com
>> Kopia : opensaf-devel@lists.sourceforge.net
>> Ämne : [devel] [PATCH 0 of 1] Review Request for imm: add scAbsenceAllowed 
>> attribute and change default value for longDnsAllowed attribute in 
>> OpensafImm class [#1625]
>>
>> Summary: imm: add scAbsenceAllowed attribute and change default value for 
>> longDnsAllowed attribute in OpensafImm class [#1625]
>> Review request for Trac Ticket(s): 1625
>> Peer Reviewer(s): Neelakanta
>> Pull request to: Zoran
>> Affected branch(es): default(5.0)
>> Development branch: default(5.0)
>>
>> --------------------------------
>> Impacted area       Impact y/n
>> --------------------------------
>> Docs                    n
>> Build system            n
>> RPM/packaging           n
>> Configuration files     n
>> Startup scripts         n
>> SAF services            y
>> OpenSAF services        n
>> Core libraries          n
>> Samples                 n
>> Tests                   n
>> Other                   n
>>
>>
>> Comments (indicate scope for each "y" above):
>> ---------------------------------------------
>>
>> changeset ddd75d23daaa3a54bf4e575e0c0c703f9894d89f
>> Author:      Zoran Milinkovic <zoran.milinko...@ericsson.com>
>> Date:        Wed, 23 Dec 2015 10:44:44 +0100
>>
>>      imm: add scAbsenceAllowed attribute and change default value for
>>      longDnsAllowed attribute in OpensafImm class [#1625]
>>
>>      New attribute 'scAbsenceAllowed' for cloud resilience is added to 
>> OpensafImm
>>      class.
>>
>>
>> Added Files:
>> ------------
>> samples/immsv/OpensafImm_Upgrade_5.0.xml
>>
>>
>> Complete diffstat:
>> ------------------
>> samples/immsv/OpensafImm_Upgrade_5.0.xml |  85 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 85 insertions(+), 0 deletions(-)
>>
>>
>> Testing Commands:
>> -----------------
>>
>>
>> Testing, Expected Results:
>> --------------------------
>>
>>
>> Conditions of Submission:
>> -------------------------
>> Ack from Neelakanta
>>
>>
>> Arch      Built     Started    Linux distro
>> -------------------------------------------
>> mips        n          n
>> mips64      n          n
>> x86         n          n
>> x86_64      n          n
>> powerpc     n          n
>> powerpc64   n          n
>>
>>
>> Reviewer Checklist:
>> -------------------
>> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>>
>>
>> Your checkin has not passed review because (see checked entries):
>>
>> ___ Your RR template is generally incomplete; it has too many blank entries
>>     that need proper data filled in.
>>
>> ___ You have failed to nominate the proper persons for review and push.
>>
>> ___ Your patches do not have proper short+long header
>>
>> ___ You have grammar/spelling in your header that is unacceptable.
>>
>> ___ You have exceeded a sensible line length in your headers/comments/text.
>>
>> ___ You have failed to put in a proper Trac Ticket # into your commits.
>>
>> ___ You have incorrectly put/left internal data in your comments/files
>>     (i.e. internal bug tracking tool IDs, product names etc)
>>
>> ___ You have not given any evidence of testing beyond basic build tests.
>>     Demonstrate some level of runtime or other sanity testing.
>>
>> ___ You have ^M present in some of your files. These have to be removed.
>>
>> ___ You have needlessly changed whitespace or added whitespace crimes
>>     like trailing spaces, or spaces before tabs.
>>
>> ___ You have mixed real technical changes with whitespace and other
>>     cosmetic code cleanup changes. These have to be separate commits.
>>
>> ___ You need to refactor your submission into logical chunks; there is
>>     too much content into a single commit.
>>
>> ___ You have extraneous garbage in your review (merge commits etc)
>>
>> ___ You have giant attachments which should never have been sent;
>>     Instead you should place your content in a public tree to be pulled.
>>
>> ___ You have too many commits attached to an e-mail; resend as threaded
>>     commits, or place in a public tree for a pull.
>>
>> ___ You have resent this content multiple times without a clear indication
>>     of what has changed between each re-send.
>>
>> ___ You have failed to adequately and individually address all of the
>>     comments and change requests that were proposed in the initial review.
>>
>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>>
>> ___ Your computer have a badly configured date and time; confusing the
>>     the threaded patch review.
>>
>> ___ Your changes affect IPC mechanism, and you don't present any results
>>     for in-service upgradability test.
>>
>> ___ Your changes affect user manual and documentation, your patch series
>>     do not contain the patch that updates the Doxygen manual.
>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> Opensaf-devel mailing list
>> Opensaf-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>>



------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to