Summary: Review request for #1556 and #1587. Review request for Trac Ticket(s): #1556 and #1587. Peer Reviewer(s): Hans, Nagendra, Minh, Quyen Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset ef50623a3fe874974e41676e785777bc2e0b1fba Author: [email protected] Date: Fri, 08 Jan 2016 18:14:28 +0530 amfnd: fix continuous restart of a inst_failed comp during su restart[#1556] During su-restart recovery or RESTART admin op, if instantiation of a component fails amfnd keeps on restarting it after each inst_failure. AMFND must give up re-instantiation of a inst_fail compoent after trying saAmfNumMaxInstantiateWithoutDelay value of comp global class or saAmfCompNumMaxInstantiateWithoutDelay value in comp class. Patch stops re-instantiation of a inst_failed comp when max retries is reached. changeset 2f74a63910c6d370b15f648d902f7b945715de43 Author: [email protected] Date: Fri, 08 Jan 2016 18:15:53 +0530 amfnd: fix amfnd crash due to inst failure of a restarting npi comp [#1587] amfnd crashes when comp instantiation fails as a part of comp restart recovery. Applicable to a NPI SU only. Crash occurs because AMFND is trying to respond to AMFD for assignment status. If a healthy comp faults in stable state of SG with comp-restart or su-restart recovery and it results in INST_FAILED state of SU, then there will be no pending assignments to AMFD. AMFND must inform to AMFD only when SU enters INST_FAILED state during handling of assignments sent by AMFD. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 87 +++++++++++++++++++++++++++++++++++++++++++----------------- osaf/services/saf/amf/amfnd/include/avnd_su.h | 2 + osaf/services/saf/amf/amfnd/su.cc | 18 ++++++++++++ osaf/services/saf/amf/amfnd/susm.cc | 33 ++++++++++++++++++---- 4 files changed, 109 insertions(+), 31 deletions(-) Testing Commands: ----------------- Tested PI SU and NPI SU configuration for the reported. Testing, Expected Results: -------------------------- No crash observed for NPI SU. No continuous restarting of a inst_fail component during su-restart recovery or RESTART admin op. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
