ack for code review
Thanks / Minh

On 1/9/2016 12:38 AM, [email protected] wrote:
>   osaf/libs/common/ntfsv/include/ntfsv_msg.h |  4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> While logging alarm notifications having additionalText > 1024, Ntf server 
> truncates
> additionalText to 1024.
>
> There is no problem with delievery of notifications having additionalText 
> >1024,
> only saflogging of alarm and security alram notifiation is affected.
>
> Patch ensures that MAX length of addtionaltext conforms to MAX value of
> logMaxLogrecsize as mentioned in LOGSV PR doc Section 3.5.2.1.
>
> diff --git a/osaf/libs/common/ntfsv/include/ntfsv_msg.h 
> b/osaf/libs/common/ntfsv/include/ntfsv_msg.h
> --- a/osaf/libs/common/ntfsv/include/ntfsv_msg.h
> +++ b/osaf/libs/common/ntfsv/include/ntfsv_msg.h
> @@ -31,7 +31,9 @@ extern "C" {
>   #define NTFS_MAX_STRING_LEN 64
>   
>   /* Common notification limits TODO: specifify */
> -#define MAX_ADDITIONAL_TEXT_LENGTH 1024
> +/*MAX length of addtionaltext conforms to MAX value of logMaxLogrecsize
> +as mentioned in LOGSV PR doc Section 3.5.2.1*/
> +#define MAX_ADDITIONAL_TEXT_LENGTH 65535
>   #define MAX_DISCARDED_NOTIFICATIONS 1024
>   
>   /* Message type enums */
>

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to