Summary: amfd: fix assignment of standby HA state in NWAY model[#1523]. Review request for Trac Ticket(s): #1523 Peer Reviewer(s): AMF contributors. Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 1256f72c4a3398710a85b5ecfdd2c9885f9269fe Author: [email protected] Date: Wed, 13 Jan 2016 18:07:21 +0530 amfd: fix assignment of standby HA state in NWAY model[1523] In the application, compcstype is not configured for csi of one si(say SI6). Unlock-in and unlock of sg leads to only active assignments for Sis execpt SI6. In assignment function avd_sg_nway_si_assign(), AMF tries to first assign active HA state for SIs. If atleast one active assignment is given, standby assignments are skipped. When all the active assignments are over same function tries to assign standby HA state. This decision is taken based on one of the flags is_act_ass_sent. Every time above function is invoked it tries to issue active assignments by setting flag is_act_ass_sent to true and then it creates SUSI. But this flag is not set to false when no SUSI (assignment) is created successfully. In the issue, all SIs execpt SI6 are assigned active HA state. In SI6, CSIs could not be assigned because compcstype is not configured for its CSI. So the flag remains true even though no SUSI for SI6 was created. This function is invoked two times a)when SG is unlocked and b) when AMF gets active assignment responses for other SIs. Since SI6 is unassigned, function will always try for active assignments for SI6 and flag is_act_ass_sent will remain true in each invocation of this function. Because of this function will always return wihtout trying for standby assignments for other SIs. In the same configuration if one tries to lock and unlock SIs other than SI6, then lock operation will fail because avd_sg_nway_si_assign() will try for assignments for both locked SI and SI6. Failure of active assignment for Si6 will change the return status of function which, eventually, results in failure of lock operation. Patch fixes the problem to set is_act_ass_sent true only when SUSI for atleast one SI is created successfully. Also patch fixes the problem related to SI lock by checking the SUSI creation for the SI. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 3 +-- osaf/services/saf/amf/amfd/si.cc | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) Testing Commands: ----------------- As per ticket desciption. SI lock and unlock of assigned SI from same configuration. Testing, Expected Results: -------------------------- Standby assignments are genereted. SI lock and unlock successful. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
