Hi, You can go ahead and push it. Please see my comment inline:
>-----Original Message----- >From: Lennart Lund [mailto:[email protected]] >Sent: Friday, January 15, 2016 8:57 PM >To: Anders Widell; Vu Minh Nguyen; Mathivanan Naickan Palanivelu >Cc: [email protected]; Lennart Lund >Subject: RE: [devel] [PATCH 1 of 1] log: switching to use the C++ compiler >[#1624] > >Hi > >This patch is acked by all reviewers but there is still the issue about not >converting the lgs_main.c file to C++. >Mathi, if there is a very good reason for keeping lgs_main.c as a C file please >give some input otherwise also this file will be C++. Yes, one can do that, as long as the community has agreed to that. Refactoring is the primary goal here, the rest are opinions w.r.t c++ as the Patch stands today. Cheers, Mathi. >This patch will be pushed during next week. > >Thanks >Lennart > >> -----Original Message----- >> From: Anders Widell >> Sent: den 15 januari 2016 12:27 >> To: Vu Minh Nguyen; Lennart Lund >> Subject: Re: [devel] [PATCH 1 of 1] log: switching to use the C++ >> compiler [#1624] >> >> I haven't heard anything from Mathi yet. What do you think Lennart, >> shall we continue waiting or go ahead and push the patch? >> >> / Anders Widell >> >> On 01/15/2016 11:46 AM, Vu Minh Nguyen wrote: >> > Hi, >> > >> > Do you have the conclusion on this? >> > >> > If not, could we go pushing this patch? >> > In future, if we decide converting lgs_main to C++, we can easily >> > doing that by removing wrapper functions that are created in >> #279 ticket. >> > >> > Regards, Vu. >> > >> >> -----Original Message----- >> >> From: Lennart Lund [mailto:[email protected]] >> >> Sent: Wednesday, January 13, 2016 4:45 PM >> >> To: Vu Minh Nguyen >> >> Subject: FW: [devel] [PATCH 1 of 1] log: switching to use the C++ >> >> compiler [#1624] >> >> >> >> Info >> >> >> >> -----Original Message----- >> >> From: Anders Widell >> >> Sent: den 13 januari 2016 09:29 >> >> To: Mathivanan Naickan Palanivelu >> >> Cc: Lennart Lund >> >> Subject: Re: [devel] [PATCH 1 of 1] log: switching to use the C++ >> >> compiler [#1624] >> >> >> >> Hi Mathi! >> >> >> >> I remember we had some discussion regarding lgs_main.c before >> Christmas, >> >> but I can't recall the reason why you thought it should remain in >> >> the C language. We now see that it will cause a lot of problems >> >> later on (we need to introduce wrapper functions to do the >> >> conversion between C and >> >> C++), so the question has come up why we can't convert the lgs_main >> >> C++file >> >> as well. Do you remember the reason? If there is no important >> >> reason to keep it in C, can we convert it to C++ already in this patch? >> >> >> >> / Anders Widell >> > > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
