Hi Neel, Reviewed the patch, ack from me. Also agree with Zoran about checking clArr before accessing it.
BR, Hung Nguyen - DEK Technologies -------------------------------------------------------------------------------- From: Neelakanta Reddy [email protected] Sent: Monday, January 18, 2016 7:28AM To: Zoran Milinkovic, Hung Nguyen [email protected], [email protected] Cc: Opensaf-devel [email protected] Subject: [PATCH 1 of 1] imm: corrected the assert checking in CCb apply when CCB is aborted [#1664] osaf/services/saf/immsv/immnd/immnd_evt.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -7899,7 +7899,11 @@ static void immnd_evt_proc_ccb_apply(IMM /*err != SA_AIS_OK => generate SaImmOiCcbAbortCallbackT upcalls */ immnd_evt_ccb_abort(cb, evt->info.ccbId, &clArr, &clArrSize, NULL); - osafassert(!clArrSize || originatedAtThisNd); + /* when the client is not originated from this ND then the client + connection must be zero. We are in apply and there will be only + one implementer connection and no augumentaion connections. + */ + osafassert(!clArr[0] || originatedAtThisNd); } TRACE_2("CCB APPLY TERMINATING CCB: %u", evt->info.ccbId); bCcbFinalize = 1; ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
