Summary: log: Use pathconf() instead of NAME_MAX [#279] Review request for Trac Ticket(s): #279 Peer Reviewer(s): Lennart, Anders, Mathi Pull request to: Lennart Affected branch(es): Default Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 236665dc60d0d56ff355f6dd3fc3d3908b0feedc Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 21 Jan 2016 09:47:49 +0700 log: Use pathconf() instead of NAME_MAX [#279] Also replace static arrays of log file name, path name by C++ string. Complete diffstat: ------------------ osaf/libs/agents/saf/lga/lga_api.c | 58 +++++++++++++++++---- osaf/libs/common/logsv/include/lgsv_defs.h | 13 ---- osaf/libs/common/logsv/include/lgsv_msg.h | 4 +- osaf/services/saf/logsv/lgs/Makefile.am | 14 ++-- osaf/services/saf/logsv/lgs/lgs.h | 12 ++- osaf/services/saf/logsv/lgs/lgs_config.cc | 84 +++++++++++++++--------------- osaf/services/saf/logsv/lgs/lgs_config.h | 7 +- osaf/services/saf/logsv/lgs/lgs_evt.cc | 61 ++++++++++++---------- osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 148 +++++++++++++++++------------------------------------- osaf/services/saf/logsv/lgs/lgs_filehdl.h | 35 +++++------- osaf/services/saf/logsv/lgs/lgs_imm.cc | 178 ++++++++++++++++++++++++++++++++--------------------------------- osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 32 +++++----- osaf/services/saf/logsv/lgs/lgs_mbcsv_v2.cc | 5 +- osaf/services/saf/logsv/lgs/lgs_mds.cc | 60 +++++++++++++++++---- osaf/services/saf/logsv/lgs/lgs_stream.cc | 261 ++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------ osaf/services/saf/logsv/lgs/lgs_stream.h | 30 ++++++---- osaf/services/saf/logsv/lgs/lgs_util.cc | 312 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------- osaf/services/saf/logsv/lgs/lgs_util.h | 29 ++++++---- 18 files changed, 674 insertions(+), 669 deletions(-) Testing Commands: ----------------- This patch does not intend to have impacts on current LOG functionalities. So, to test it, run the whole log test suite. Testing, Expected Results: -------------------------- All test cases PASS Conditions of Submission: ------------------------- Get ack from reviewers. Hope to receive feedback within one week. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel