Summary: amfd: replace internal use of SaNameT with std::string [#1537]
Review request for Trac Ticket(s): 1537
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Whenever possible, SaNameT is replaced with std::string in amfd. Except:
* IMM callbacks where SaNameT is specified in the function prototype
* checkpoint messages are still encoded as SaNameT for backwards compatibility
with existing amfd version
* messages between d and nd have not been changed
changeset 4390a3d3b078620d9a9cfc05b600992a79ea5a3f
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:18:17 +1100
amd libs: move avsv_saname_init to amfd [#1537]
this is only used in amfd
changeset c338555a96c9b2d93df24e689b6c932fc83147fa
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:18:18 +1100
leap: add function to encode SaNameT from SaConstString [#1537]
changeset c7c826a976e508599954279edc0c7f5e44bb2210
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:23 +1100
amfd: added wrapper class for SaNameT [#1537]
SaNameTWrapper allows easy conversion from std::string to SaNameT
required
by many API functions
changeset 01d5454fc4b662a4a6442ea0c27941a236930c99
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:25 +1100
amfd: change SaNameT variables to std::string in include directory
[#1537]
change all appropriate SaNameT variables to type std::string in
amfd/include
changeset 6e480108743d55218713817c61ccd24b2b79524d
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:25 +1100
afmd: change SaNameT to std::string in ckpt related files [#1537]
changeset 191e23a5ad4a2cea5f25eb10351b762b827b81e0
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:25 +1100
amfd: change SaNameT to std::string [#1537]
changeset 563bdfff4697f2bdf0f58d351dfcd3dcec92d76f
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:25 +1100
amfd: change SaNameT to std::string [#1537]
changeset 3f503db3ba8b4996d7ef215a0f36e7c8634a22eb
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:25 +1100
amfd: change SaNameT to std::string [#1537]
changeset f280b0fe4b561009fb45413d00fef4e6cb320406
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: change SaNameT to std::string [#1537]
changeset ced5e2270f0038b8cb0f283737ff223870e81c01
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: change SaNameT to std::string in SG related code [#1537]
changeset 84bc1ce13350cdb8a5b876134d7c31b188c6766b
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: change SaNameT to std::string in SI related code [#1537]
changeset d459be99c1f13532386109caf4e8bb47e9c96307
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: change SaNameT to std::string in sirankedsu.cc [#1537]
changeset cb33a0f047ef9a9854164f0c833a7ec953a3bff6
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: change SaNameT to std::string in SU related code [#1537]
changeset bb72c6b3b03b8f4a998abd4f6947bfe2ff6c7871
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: change SaNameT to std::string in util.cc [#1537]
changeset 4c91c2ef5ecd751b5af234780c8fa1a59d24ab96
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 25 Jan 2016 11:19:26 +1100
amfd: update unit tests to use std::string [#1537]
Complete diffstat:
------------------
osaf/libs/common/amf/include/amf_util.h | 1 -
osaf/libs/common/amf/util.c | 17 -----
osaf/libs/core/include/ncsencdec_pub.h | 1 +
osaf/libs/core/leap/hj_enc.c | 17 +++++
osaf/services/saf/amf/amfd/app.cc | 68
++++++++++----------
osaf/services/saf/amf/amfd/apptype.cc | 61 ++++++++++--------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 134
++++++++++++++++++++++++++--------------
osaf/services/saf/amf/amfd/ckpt_enc.cc | 121
++++++++++++++++++-------------------
osaf/services/saf/amf/amfd/ckpt_updt.cc | 94
++++++++++++++--------------
osaf/services/saf/amf/amfd/clm.cc | 14 ++--
osaf/services/saf/amf/amfd/cluster.cc | 2 +-
osaf/services/saf/amf/amfd/comp.cc | 169
+++++++++++++++++++++++++++-------------------------
osaf/services/saf/amf/amfd/compcstype.cc | 174
++++++++++++++++++++++++++---------------------------
osaf/services/saf/amf/amfd/comptype.cc | 43 ++++++------
osaf/services/saf/amf/amfd/csi.cc | 248
+++++++++++++++++++++++++++++++++++++++++++---------------------------------
osaf/services/saf/amf/amfd/csiattr.cc | 4 +-
osaf/services/saf/amf/amfd/cstype.cc | 55 +++++-----------
osaf/services/saf/amf/amfd/ctcstype.cc | 67
++++++++++----------
osaf/services/saf/amf/amfd/hlt.cc | 14 ++--
osaf/services/saf/amf/amfd/hlttype.cc | 18 ++---
osaf/services/saf/amf/amfd/imm.cc | 281
++++++++++++++++++++++++++++++++++++++++++--------------------------------------------
osaf/services/saf/amf/amfd/include/app.h | 6 +-
osaf/services/saf/amf/amfd/include/apptype.h | 8 +-
osaf/services/saf/amf/amfd/include/cb.h | 4 +-
osaf/services/saf/amf/amfd/include/ckpt.h | 4 +-
osaf/services/saf/amf/amfd/include/cluster.h | 6 +-
osaf/services/saf/amf/amfd/include/comp.h | 52 ++++++++--------
osaf/services/saf/amf/amfd/include/csi.h | 26 ++++----
osaf/services/saf/amf/amfd/include/db_template.h | 39 +++++++++++-
osaf/services/saf/amf/amfd/include/evt.h | 22 +++---
osaf/services/saf/amf/amfd/include/imm.h | 19 +++--
osaf/services/saf/amf/amfd/include/node.h | 18 ++--
osaf/services/saf/amf/amfd/include/ntf.h | 34 +++++-----
osaf/services/saf/amf/amfd/include/pg.h | 2 +-
osaf/services/saf/amf/amfd/include/proc.h | 18 ++--
osaf/services/saf/amf/amfd/include/sg.h | 8 +-
osaf/services/saf/amf/amfd/include/sgtype.h | 8 +-
osaf/services/saf/amf/amfd/include/si.h | 12 +-
osaf/services/saf/amf/amfd/include/si_dep.h | 16 ++--
osaf/services/saf/amf/amfd/include/su.h | 16 ++--
osaf/services/saf/amf/amfd/include/susi.h | 14 ++--
osaf/services/saf/amf/amfd/include/sutcomptype.h | 4 +-
osaf/services/saf/amf/amfd/include/sutype.h | 6 +-
osaf/services/saf/amf/amfd/include/svctype.h | 4 +-
osaf/services/saf/amf/amfd/include/svctypecstype.h | 6 +-
osaf/services/saf/amf/amfd/include/timer.h | 5 +-
osaf/services/saf/amf/amfd/include/util.h | 14 ++-
osaf/services/saf/amf/amfd/ndfsm.cc | 12 +-
osaf/services/saf/amf/amfd/ndproc.cc | 32 ++++-----
osaf/services/saf/amf/amfd/node.cc | 227
+++++++++++++++++++++++++++++++++------------------------------------
osaf/services/saf/amf/amfd/nodegroup.cc | 215
+++++++++++++++++++++++++++++++++++-------------------------------
osaf/services/saf/amf/amfd/nodeswbundle.cc | 46 +++++++------
osaf/services/saf/amf/amfd/ntf.cc | 114
++++++++++++++++++----------------
osaf/services/saf/amf/amfd/pg.cc | 2 +-
osaf/services/saf/amf/amfd/sg.cc | 233
++++++++++++++++++++++++++++++++++++-----------------------------------
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 414
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 60 +++++++++---------
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 196
++++++++++++++++++++++++++++++------------------------------
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 250
++++++++++++++++++++++++++++++++++++++---------------------------------------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 148
+++++++++++++++++++++++-----------------------
osaf/services/saf/amf/amfd/sgproc.cc | 166
+++++++++++++++++++++++++-------------------------
osaf/services/saf/amf/amfd/sgtype.cc | 49 +++++++-------
osaf/services/saf/amf/amfd/si.cc | 233
++++++++++++++++++++++++++++++++++++-----------------------------------
osaf/services/saf/amf/amfd/si_dep.cc | 297
++++++++++++++++++++++++++++++++++++++++---------------------------------------------------
osaf/services/saf/amf/amfd/siass.cc | 107
++++++++++++++++----------------
osaf/services/saf/amf/amfd/sirankedsu.cc | 143
+++++++++++++++++--------------------------
osaf/services/saf/amf/amfd/su.cc | 444
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------
osaf/services/saf/amf/amfd/sutcomptype.cc | 25 +++----
osaf/services/saf/amf/amfd/sutype.cc | 65
++++++++++---------
osaf/services/saf/amf/amfd/svctype.cc | 44 +++++++------
osaf/services/saf/amf/amfd/svctypecstypes.cc | 39 ++++++-----
osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 33 ++++-----
osaf/services/saf/amf/amfd/util.cc | 205
+++++++++++++++++++++++++++++++++++++++------------------------
73 files changed, 2954 insertions(+), 2819 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
