Hi Hans Thanks, please see my reply below.
> On 27 Jan 2016, at 11:45 PM, Hans Nordebäck <[email protected]> > wrote: > > ack, code review only. Minor question below. /Thanks HansN > > On 01/25/2016 05:35 AM, Gary Lee wrote: >> osaf/services/saf/amf/amfd/include/db_template.h | 39 >> +++++++++++++++++++++++- >> 1 files changed, 38 insertions(+), 1 deletions(-) >> >> + > [HansN] is this comment correct? Isn't name returned by value, i.e copied? >> + // note: SaNameT will become invalid if this SaNameTWrapper is destroyed >> + operator const SaNameT() const { >> + return name; >> + } Yes, the caller has a copy. But there might be a pointer inside SaNameT if length is >= SA_MAX_UNEXTENDED_NAME_LENGTH. The original pointer is freed when the wrapper is destroyed, and this copy becomes dangling. Thanks Gary ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
