Summary: cpsv: CPD starts retention duration timer if the checkpoint is no longer used [#1670] Review request for Trac Ticket(s): 1670 Peer Reviewer(s): [email protected]; [email protected] Pull request to: [email protected]; Affected branch(es): 4.6; 4.7; default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 8c34978be92b32e270e8336c1b78adf8c36b1dff Author: Nhat Pham <[email protected]> Date: Fri, 29 Jan 2016 10:23:44 +0700 cpsv: CPD starts retention duration timer if the checkpoint is no longer used [#1670] Problem: -------- A non-collocated checkpoint is created on PL3 with retention duration = 0. Then it is opened on PL4. In case the PL3 restarts, the checkpoint is destroyed althougth there is a client on PL4 using it. This happens because the CPD uses incorrect algorithm to start retention duration timer. Solution: -------- The CPD starts retention duration timer if the checkpoint is no longer used (i.e num_users = 0) Complete diffstat: ------------------ osaf/services/saf/cpsv/cpd/cpd_proc.c | 24 +++++++++++------------- 1 files changed, 11 insertions(+), 13 deletions(-) Testing Commands: ----------------- Following steps described in ticket 1670 Testing, Expected Results: -------------------------- Refer the ticket 1670 Conditions of Submission: ------------------------- - Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
