Summary: cpsv: To correct converting section id to string [#1666] Review request for Trac Ticket(s): 1666 Peer Reviewer(s): [email protected]; [email protected] Pull request to: [email protected] Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 590eea6af108dd7c4ae425f7d10a0835d210ae61 Author: Nhat Pham <[email protected]> Date: Fri, 29 Jan 2016 14:01:30 +0700 ckpt: To add a test case to verify creating section with long id [#1666] changeset 8ed45f073c46a42a56296e739eeeaa30ead6983f Author: Nhat Pham <[email protected]> Date: Mon, 01 Feb 2016 09:55:29 +0700 cpsv: To correct converting section id to string [#1666] Complete diffstat: ------------------ osaf/libs/common/cpsv/cpsv_evt.c | 14 +++++++++++--- tests/cpsv/test_cpa.c | 33 +++++++++++++++++++++++++++++++++ tests/cpsv/test_cpa_util.c | 4 ++++ tests/cpsv/test_cpsv.h | 1 + tests/cpsv/test_cpsv_conf.h | 2 ++ 5 files changed, 51 insertions(+), 3 deletions(-) Testing Commands: ----------------- ckpttest 11 15 Testing, Expected Results: -------------------------- The test case passes. Conditions of Submission: ------------------------- - Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
