Hi Nagu, Can you describe your backward compatibility test case? It looks to me that the new attr saAmfUnassignedAlarmStatus was not added to IMM while standby amfd was running cloud resilience version
Thanks, Minh On 04/02/16 20:08, Nagendra Kumar wrote: > Hi Minh, > While testing backward compatibility with older branches, I > found that Standby Amfd(not configured with IMMSV_SC_ABSENCE_ALLOWED) is not > coming up: > > Feb 4 14:36:52 PM_SC-2 osafamfd[32168]: Started > Feb 4 14:36:53 PM_SC-2 osafimmnd[32118]: NO SearchInit ERR_INVALID_PARAM: > attribute saAmfUnassignedAlarmStatus does not exist in class SaAmfSI > Feb 4 14:36:53 PM_SC-2 osafamfd[32168]: ER avd_si_config_get: > saImmOmSearchInitialize_2 failed: 7 > Feb 4 14:36:53 PM_SC-2 osafamfd[32168]: ER Failed to read configuration, AMF > will not start > Feb 4 14:36:53 PM_SC-2 osafamfd[32168]: ER avd_imm_config_get FAILED > Feb 4 14:36:53 PM_SC-2 osafamfd[32168]: ER avd_standby_role_initialization > FAILED > Feb 4 14:36:53 PM_SC-2 osafamfd[32168]: ER initialize failed, exiting > Feb 4 14:36:53 PM_SC-2 opensafd[32056]: ER Failed DESC:AMFD > > Thanks > -Nagu >> -----Original Message----- >> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] >> Sent: 20 January 2016 09:03 >> To: hans.nordeb...@ericsson.com; gary....@dektech.com.au; Nagendra >> Kumar; Praveen Malviya; minh.c...@dektech.com.au >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: [PATCH 0 of 5] Review Request for amf: Add support for cloud >> resilience [#1620] V2 >> >> Summary: amf: Add support for cloud resilience [#1620] V2 Review request >> for Trac Ticket(s): 1620 Peer Reviewer(s): AMF contributors Pull request to: >> AMF maintainers Affected branch(es): default Development branch: default >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> Patch series V2 update from HansN's comments >> >> changeset fedabfe441ae9019d84ffe51cec26751c413e9d8 >> Author: Minh Hon Chau <minh.c...@dektech.com.au> >> Date: Wed, 20 Jan 2016 14:26:58 +1100 >> >> amfd: Add README file for cloud resilience support [#1620] V2 >> >> changeset 8872be90c2c0af3228f672c1c7a31b787ec60077 >> Author: Minh Hon Chau <minh.c...@dektech.com.au> >> Date: Wed, 20 Jan 2016 14:26:58 +1100 >> >> amfd: Add support for cloud resilience at director [#1620] V2 >> Outlined >> changes: . node_up_msg event handling has changed so that amfd >> can collect >> the sync information sent from amfnd . Node Sync timer is >> introduced as a >> window of amfnd sync from headless . Failover may happens during >> headless, >> adjust_delayed_failover() to balance the assignment in term of >> active/standby availability . SI dependencies also can change due to >> assignment removal during headless adjust_delayed_sidep() to >> update the si >> dependencies >> >> changeset 0402476971ca7e05e9fedb2a25aac7df312e12ef >> Author: Minh Hon Chau <minh.c...@dektech.com.au> >> Date: Wed, 20 Jan 2016 14:26:58 +1100 >> >> amfnd: Add support for cloud resilience at node director [#1620] V2 >> Outline >> changes: . amfnd does not reboot if amfd is down . >> Failover/switchover >> recovery is limited during headless, only componentRestart and >> suRestart is >> supported . SC absence timer is introduced, node will reboot if >> timeout . >> amfnd sends sync information if amfd is up after headless >> >> changeset f6d73b13f9cdab1d4ef885ea0933eb4237c70d84 >> Author: Minh Hon Chau <minh.c...@dektech.com.au> >> Date: Wed, 20 Jan 2016 14:26:58 +1100 >> >> amfd: Add support for cloud resilience at common libs [#1620] V2 >> Outlined >> changes: . Introduce messages sisu_state_info and >> csicomp_state_info to >> carry sync information which are sent to amfd to recover from >> headless . >> Some encode/decode functions for these 2 new messages >> >> changeset 6a01a07c467477811d10bbfe383d5a65ef2a2eb4 >> Author: Minh Hon Chau <minh.c...@dektech.com.au> >> Date: Wed, 20 Jan 2016 14:26:58 +1100 >> >> amfd: Add saAmfUnassignedAlarmStatus attribute to memorize the >> alarm_sent >> status [#1620] >> >> If the SI Unassigned Alarm is raised before headless by locking SU for >> instance, then after cluster recovers from headless and unlocking the >> SU, >> this alarm is not cleared. As the application can reside in PL nodes >> and >> it's right to expect the previous raised alarm should be cleared once >> the SI >> gets back assignments. The patch adds new attribute >> saAmfUnassignedAlarmStatus attribute to SaAmfSI class to >> memorize the >> variable alarm_sent for headless. >> >> >> Complete diffstat: >> ------------------ >> osaf/libs/common/amf/d2nedu.c | 311 >> ++++++++++++++++++++++++++++++++++++++++++++++++---- >> osaf/libs/common/amf/d2nmsg.c | 266 >> +++++++++++++++++++++++++++++++++++++++++++++ >> osaf/libs/common/amf/include/Makefile.am | 1 + >> osaf/libs/common/amf/include/amf_d2nedu.h | 16 ++ >> osaf/libs/common/amf/include/amf_d2nmsg.h | 61 ++++++++++ >> osaf/libs/common/amf/include/amf_defs.h | 3 + >> osaf/libs/common/amf/include/amf_si_assign.h | 49 ++++++++ >> osaf/services/saf/amf/README-HEADLESS | 123 >> +++++++++++++++++++++ >> osaf/services/saf/amf/amfd/cluster.cc | 69 +++++++++++- >> osaf/services/saf/amf/amfd/comp.cc | 8 +- >> osaf/services/saf/amf/amfd/csi.cc | 107 ++++++++++++++++++ >> osaf/services/saf/amf/amfd/imm.cc | 58 +++++++++ >> osaf/services/saf/amf/amfd/include/cb.h | 5 + >> osaf/services/saf/amf/amfd/include/cluster.h | 1 + >> osaf/services/saf/amf/amfd/include/csi.h | 2 + >> osaf/services/saf/amf/amfd/include/db_template.h | 1 + >> osaf/services/saf/amf/amfd/include/evt.h | 3 + >> osaf/services/saf/amf/amfd/include/mds.h | 7 +- >> osaf/services/saf/amf/amfd/include/msg.h | 2 +- >> osaf/services/saf/amf/amfd/include/node.h | 3 + >> osaf/services/saf/amf/amfd/include/proc.h | 7 + >> osaf/services/saf/amf/amfd/include/sg.h | 16 ++- >> osaf/services/saf/amf/amfd/include/si.h | 1 + >> osaf/services/saf/amf/amfd/include/susi.h | 3 + >> osaf/services/saf/amf/amfd/include/timer.h | 1 + >> osaf/services/saf/amf/amfd/include/util.h | 2 +- >> osaf/services/saf/amf/amfd/main.cc | 24 ++++ >> osaf/services/saf/amf/amfd/mds.cc | 4 +- >> osaf/services/saf/amf/amfd/ndfsm.cc | 325 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++-- >> osaf/services/saf/amf/amfd/ndmsg.cc | 18 ++- >> osaf/services/saf/amf/amfd/ndproc.cc | 103 +++++++++++++++++- >> osaf/services/saf/amf/amfd/node.cc | 17 +- >> osaf/services/saf/amf/amfd/sg.cc | 57 +++++++++ >> osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 140 >> ++++++++++++++++++++++++ >> osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 6 + >> osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 24 ++++ >> osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 24 ++++ >> osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 6 + >> osaf/services/saf/amf/amfd/sgproc.cc | 47 +++++++- >> osaf/services/saf/amf/amfd/si.cc | 43 +++++- >> osaf/services/saf/amf/amfd/siass.cc | 121 >> ++++++++++++++++++++ >> osaf/services/saf/amf/amfd/su.cc | 19 +-- >> osaf/services/saf/amf/amfnd/clc.cc | 100 ++++++++++------ >> osaf/services/saf/amf/amfnd/clm.cc | 11 +- >> osaf/services/saf/amf/amfnd/comp.cc | 42 ++++++- >> osaf/services/saf/amf/amfnd/compdb.cc | 45 ++++++- >> osaf/services/saf/amf/amfnd/di.cc | 419 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> ++++++++- >> osaf/services/saf/amf/amfnd/err.cc | 110 +++++++++++++++++- >> osaf/services/saf/amf/amfnd/evt.cc | 2 + >> osaf/services/saf/amf/amfnd/hcdb.cc | 8 +- >> osaf/services/saf/amf/amfnd/include/avnd_cb.h | 13 ++- >> osaf/services/saf/amf/amfnd/include/avnd_comp.h | 17 +-- >> osaf/services/saf/amf/amfnd/include/avnd_di.h | 4 + >> osaf/services/saf/amf/amfnd/include/avnd_evt.h | 2 + >> osaf/services/saf/amf/amfnd/include/avnd_mds.h | 4 +- >> osaf/services/saf/amf/amfnd/include/avnd_proc.h | 1 + >> osaf/services/saf/amf/amfnd/include/avnd_su.h | 4 +- >> osaf/services/saf/amf/amfnd/include/avnd_tmr.h | 1 + >> osaf/services/saf/amf/amfnd/include/avnd_util.h | 4 + >> osaf/services/saf/amf/amfnd/main.cc | 103 +++++++++++++++++- >> osaf/services/saf/amf/amfnd/mds.cc | 19 ++- >> osaf/services/saf/amf/amfnd/sidb.cc | 9 +- >> osaf/services/saf/amf/amfnd/su.cc | 39 ++++-- >> osaf/services/saf/amf/amfnd/susm.cc | 103 +++++++++------- >> osaf/services/saf/amf/amfnd/tmr.cc | 1 + >> osaf/services/saf/amf/amfnd/util.cc | 153 >> ++++++++++++++++++++++++++- >> osaf/services/saf/amf/config/amf_classes.xml | 8 + >> 67 files changed, 3076 insertions(+), 250 deletions(-) >> >> >> Testing Commands: >> ----------------- >> To test this feature, needs patches of #1625, #1646 as minimal and >> preferly >> to have patches of #1179, #1180 and #1621 >> Test: bring down both SCs, and start SCs back >> >> >> Testing, Expected Results: >> -------------------------- >> PL nodes do not reboot, and cluster comes back healthy after SCs come >> back from headless >> >> >> Conditions of Submission: >> ------------------------- >> Ack from reviewers >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 y y >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your >> headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
