Hi Minh, I am going through the patches.
Thanks, Praveen On 10-Feb-16 11:32 AM, minh chau wrote: > Hi Lennart, Praveen > > If you are not too busy, can you help to review the patches of #1180? > > Thanks, > Minh >>> -----Original Message----- >>> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] >>> Sent: den 23 december 2015 05:02 >>> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen >>> Cc: opensaf-devel@lists.sourceforge.net >>> Subject: [PATCH 0 of 5] Review Request for ntf: Add cloud resilience >>> support >>> [#1180] >>> >>> Summary: ntf: Add cloud resilience support [#1180] >>> Review request for Trac Ticket(s): 1180 >>> Peer Reviewer(s): Lennart, Praveen, Vu >>> Pull request to: NTF maintainers >>> Affected branch(es): default >>> Development branch: default >>> >>> -------------------------------- >>> Impacted area Impact y/n >>> -------------------------------- >>> Docs n >>> Build system n >>> RPM/packaging n >>> Configuration files n >>> Startup scripts y >>> SAF services n >>> OpenSAF services n >>> Core libraries n >>> Samples n >>> Tests n >>> Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> --------------------------------------------- >>> <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> >>> >>> changeset ee355e909a4b0790ef6ae0ce1c04f44f0242c18c >>> Author: Minh Hon Chau <minh.c...@dektech.com.au> >>> Date: Wed, 23 Dec 2015 14:56:14 +1100 >>> >>> NTF: Add support cloud resilience for NTF Agent [#1180] >>> >>> The patch contains support for cloud resilience feature in NTF >>> Agent code. >>> Please refer README.HYDRA for content of the changes >>> >>> changeset 121918a195dc9eec3b5bef0c0ca34eaa838a352c >>> Author: Minh Hon Chau <minh.c...@dektech.com.au> >>> Date: Wed, 23 Dec 2015 14:56:18 +1100 >>> >>> NTF: Add support cloud resilience for NTF libs common [#1180] >>> >>> The patch contains support for cloud resilience feature in NTF >>> libs common >>> which are mostly used in Agent code >>> >>> changeset 86f0a6e7299c8505118ff7176bcbf6dd56810af8 >>> Author: Minh Hon Chau <minh.c...@dektech.com.au> >>> Date: Wed, 23 Dec 2015 14:56:25 +1100 >>> >>> NTF: Add new README file for description of cloud resilience >>> support [#1180] >>> >>> Add description regarding general solution and API >>> implementation for cloud >>> resilience support in NTF >>> >>> changeset 6ae803a5593de4682ef0826ecd4ce716c40ed4a9 >>> Author: Minh Hon Chau <minh.c...@dektech.com.au> >>> Date: Wed, 23 Dec 2015 14:56:30 +1100 >>> >>> NTF: Add tests for NTF cloud resilience feature [#1180] >>> >>> The patch adds new test cases to ntftest for cloud resilience >>> feature. >>> >>> changeset 669cea5b2e95f416557a8cf68fbe1caebf4b7f43 >>> Author: Minh Hon Chau <minh.c...@dektech.com.au> >>> Date: Wed, 23 Dec 2015 14:56:33 +1100 >>> >>> NTF: Add wrapper for usage of NTF API in ntftools to handle >>> TRY_AGAIN >>> [#1180] >>> >>> Since NTF support the SC outage which the NTF client has to >>> handle TRY_AGAIN >>> return code, the patch adds wrapper for APIs being used in >>> ntftools that >>> shall receives TRY_AGAIN when both SCs are down. >>> >>> >>> Complete diffstat: >>> ------------------ >>> osaf/libs/agents/saf/ntfa/ntfa.h | 31 +- >>> osaf/libs/agents/saf/ntfa/ntfa_api.c | 672 +++++++++++++--- >>> osaf/libs/agents/saf/ntfa/ntfa_mds.c | 6 +- >>> osaf/libs/agents/saf/ntfa/ntfa_util.c | 465 +++++++++++- >>> osaf/libs/common/ntfsv/include/ntfsv_mem.h | 7 + >>> osaf/libs/common/ntfsv/include/ntfsv_msg.h | 1 + >>> osaf/libs/common/ntfsv/ntfsv_mem.c | 159 +++ >>> osaf/services/saf/ntfsv/README.HYDRA | 110 ++ >>> osaf/tools/safntf/include/ntfclient.h | 25 + >>> osaf/tools/safntf/ntfread/ntfread.c | 16 +- >>> osaf/tools/safntf/ntfsend/ntfsend.c | 24 +- >>> osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 22 +- >>> osaf/tools/safntf/src/ntfclient.c | 158 +++ >>> tests/ntfsv/Makefile.am | 4 +- >>> tests/ntfsv/tet_ntf.h | 4 +- >>> tests/ntfsv/tet_ntf_api_wrapper.c | 438 ++++++++++ >>> tests/ntfsv/tet_ntf_common.c | 67 + >>> tests/ntfsv/tet_ntf_common.h | 187 ++++ >>> tests/ntfsv/tet_ntf_main.c | 155 +++- >>> tests/ntfsv/tet_scOutage_reinitializeHandle.c | 1021 >>> +++++++++++++++++++++++++ >>> 20 files changed, 3372 insertions(+), 200 deletions(-) >>> >>> >>> Testing Commands: >>> ----------------- >>> Run ntftest suite 37, 38, 39, the new tests need the cloud resilience >>> support patches from IMM and AMF though >>> >>> >>> Testing, Expected Results: >>> -------------------------- >>> All ntftest suites pass >>> >>> >>> Conditions of Submission: >>> ------------------------- >>> Ack from reviewer >>> >>> >>> Arch Built Started Linux distro >>> ------------------------------------------- >>> mips n n >>> mips64 n n >>> x86 n n >>> x86_64 y y >>> powerpc n n >>> powerpc64 n n >>> >>> >>> Reviewer Checklist: >>> ------------------- >>> [Submitters: make sure that your review doesn't trigger any checkmarks!] >>> >>> >>> Your checkin has not passed review because (see checked entries): >>> >>> ___ Your RR template is generally incomplete; it has too many blank >>> entries >>> that need proper data filled in. >>> >>> ___ You have failed to nominate the proper persons for review and push. >>> >>> ___ Your patches do not have proper short+long header >>> >>> ___ You have grammar/spelling in your header that is unacceptable. >>> >>> ___ You have exceeded a sensible line length in your >>> headers/comments/text. >>> >>> ___ You have failed to put in a proper Trac Ticket # into your commits. >>> >>> ___ You have incorrectly put/left internal data in your comments/files >>> (i.e. internal bug tracking tool IDs, product names etc) >>> >>> ___ You have not given any evidence of testing beyond basic build tests. >>> Demonstrate some level of runtime or other sanity testing. >>> >>> ___ You have ^M present in some of your files. These have to be removed. >>> >>> ___ You have needlessly changed whitespace or added whitespace crimes >>> like trailing spaces, or spaces before tabs. >>> >>> ___ You have mixed real technical changes with whitespace and other >>> cosmetic code cleanup changes. These have to be separate commits. >>> >>> ___ You need to refactor your submission into logical chunks; there is >>> too much content into a single commit. >>> >>> ___ You have extraneous garbage in your review (merge commits etc) >>> >>> ___ You have giant attachments which should never have been sent; >>> Instead you should place your content in a public tree to be >>> pulled. >>> >>> ___ You have too many commits attached to an e-mail; resend as threaded >>> commits, or place in a public tree for a pull. >>> >>> ___ You have resent this content multiple times without a clear >>> indication >>> of what has changed between each re-send. >>> >>> ___ You have failed to adequately and individually address all of the >>> comments and change requests that were proposed in the initial >>> review. >>> >>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >>> >>> ___ Your computer have a badly configured date and time; confusing the >>> the threaded patch review. >>> >>> ___ Your changes affect IPC mechanism, and you don't present any results >>> for in-service upgradability test. >>> >>> ___ Your changes affect user manual and documentation, your patch series >>> do not contain the patch that updates the Doxygen manual. >> > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
