Summary: log: add support for cloud resilience feature [#1179]
Review request for Trac Ticket(s): #1179
Peer Reviewer(s): Mathi, Anders W, Lennart
Pull request to: Lennart
Affected branch(es): Default
Development branch: Default

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------
 <<EXPLAIN/COMMENT THE PATCH SERIES HERE>>

changeset 08366f34362e1846be86fd982163c6001bb6b33a
Author: Lennart Lund <lennart.l...@ericsson.com>
Date:   Fri, 22 Jan 2016 12:20:27 +0700

        log: add support for cloud resilience feature (service part) [#1179]

        The patch makes LOG service be able to handle the case that both SC 
nodes
        are down at the same time. When one or both nodes go up again the log
        service must be able to resume its work preferably without actions by 
the
        clients.

        A log client should not have to be aware of if one or both SC nodes are
        down. The only thing that should happen is that a TRY AGAIN (and in some
        cases TIMEOUT) returned. It is the responsibility of the client to 
decide
        how to handle this.

changeset 2cb2d3cdb882232492b7bf7c4a877d4ace8b5b2b
Author: Lennart Lund <lennart.l...@ericsson.com>
Date:   Fri, 22 Jan 2016 12:20:27 +0700

        log: add support for cloud resilience feature (agent part) [#1179]

        The patch makes LOG service be able to handle the case that both SC 
nodes
        are down at the same time. When one or both nodes go up again the log
        service must be able to resume its work preferably without actions by 
the
        clients.

        A log client should not have to be aware of if one or both SC nodes are
        down. The only thing that should happen is that a TRY AGAIN (and in some
        cases TIMEOUT) returned. It is the responsibility of the client to 
decide
        how to handle this.

changeset 0215f914e77f12c0eb8724576bb52582494f4a29
Author: Lennart Lund <lennart.l...@ericsson.com>
Date:   Fri, 22 Jan 2016 12:20:27 +0700

        log: add support for cloud resilience feature (test part) [#1179]

        The patch makes LOG service be able to handle the case that both SC 
nodes
        are down at the same time. When one or both nodes go up again the log
        service must be able to resume its work preferably without actions by 
the
        clients.

        A log client should not have to be aware of if one or both SC nodes are
        down. The only thing that should happen is that a TRY AGAIN (and in some
        cases TIMEOUT) returned. It is the responsibility of the client to 
decide
        how to handle this.

changeset 843f3440b597e64880224b48e792e3e4665cfec6
Author: Lennart Lund <lennart.l...@ericsson.com>
Date:   Fri, 22 Jan 2016 12:20:27 +0700

        log: add support for cloud resilience feature (readme file) [#1179]

        The patch makes LOG service be able to handle the case that both SC 
nodes
        are down at the same time. When one or both nodes go up again the log
        service must be able to resume its work preferably without actions by 
the
        clients.

        A log client should not have to be aware of if one or both SC nodes are
        down. The only thing that should happen is that a TRY AGAIN (and in some
        cases TIMEOUT) returned. It is the responsibility of the client to 
decide
        how to handle this.


Added Files:
------------
 osaf/libs/agents/saf/lga/lga_state.c
 osaf/libs/agents/saf/lga/lga_state.h
 osaf/services/saf/logsv/lgs/lgs_recov.cc
 osaf/services/saf/logsv/lgs/lgs_recov.h
 osaf/services/saf/logsv/README-HEADLESS
 tests/logsv/tet_Log_recov.c


Complete diffstat:
------------------
 osaf/libs/agents/saf/lga/Makefile.am       |     6 +-
 osaf/libs/agents/saf/lga/lga.h             |    53 +++-
 osaf/libs/agents/saf/lga/lga_api.c         |   858 
++++++++++++++++++++++++++++++++++++++++++++++--------------------
 osaf/libs/agents/saf/lga/lga_mds.c         |    46 ++-
 osaf/libs/agents/saf/lga/lga_state.c       |   670 
+++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/libs/agents/saf/lga/lga_state.h       |    41 +++
 osaf/libs/agents/saf/lga/lga_util.c        |    94 ++++++-
 osaf/services/saf/logsv/README-HEADLESS    |   230 +++++++++++++++++
 osaf/services/saf/logsv/lgs/Makefile.am    |     6 +-
 osaf/services/saf/logsv/lgs/lgs.h          |    12 +
 osaf/services/saf/logsv/lgs/lgs_cb.h       |    14 +
 osaf/services/saf/logsv/lgs/lgs_evt.cc     |    66 ++++-
 osaf/services/saf/logsv/lgs/lgs_evt.h      |     5 +
 osaf/services/saf/logsv/lgs/lgs_file.cc    |     5 +
 osaf/services/saf/logsv/lgs/lgs_file.h     |     1 +
 osaf/services/saf/logsv/lgs/lgs_filehdl.cc |   424 
++++++++++++++++++++++++++++++++-
 osaf/services/saf/logsv/lgs/lgs_filehdl.h  |    21 +
 osaf/services/saf/logsv/lgs/lgs_imm.cc     |   541 
++++++++++++++++++++++++++++++++++++++++-
 osaf/services/saf/logsv/lgs/lgs_main.cc    |   134 +++++++++-
 osaf/services/saf/logsv/lgs/lgs_mbcsv.cc   |    22 +-
 osaf/services/saf/logsv/lgs/lgs_recov.cc   |   758 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/saf/logsv/lgs/lgs_recov.h    |    37 ++
 osaf/services/saf/logsv/lgs/lgs_stream.cc  |    65 +++-
 osaf/services/saf/logsv/lgs/lgs_stream.h   |    28 +-
 osaf/services/saf/logsv/lgs/lgs_util.cc    |    50 +++-
 osaf/services/saf/logsv/lgs/lgs_util.h     |     4 +
 tests/logsv/Makefile.am                    |     1 +
 tests/logsv/README                         |     4 +
 tests/logsv/logtest.c                      |   290 ++++++++++++++++++++-
 tests/logsv/logtest.h                      |    57 ++++
 tests/logsv/logtestfr.c                    |     6 +-
 tests/logsv/saflogtest.c                   |    46 ++-
 tests/logsv/tet_Log_misc.c                 |    24 +-
 tests/logsv/tet_Log_recov.c                |  1837 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 34 files changed, 6056 insertions(+), 400 deletions(-)


Testing Commands:
-----------------
 Test suite #9 and #10 are added to test this feature,
 but needs to have IMM (#1625) and AMF (#1620) pushed.

 For now, to test it, can hard code "lgs_cb.scAbsenceAllowed = 1"
 to make logsv enter headless mode, then run all test suites.

Testing, Expected Results:
--------------------------
 All tests PASS


Conditions of Submission:
-------------------------
 Get ack from reviewers.


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to