Corrected ticket number to #1682 > -----Original Message----- > From: Nagendra Kumar > Sent: 18 February 2016 20:39 > To: [email protected]; Praveen Malviya; > [email protected]; [email protected] > Cc: [email protected] > Subject: [devel] [PATCH 0 of 1] Review Request for amfnd: delay > csi_remove_done for NPI comp [#1682] > > Summary: amfnd: delay csi_remove_done for NPI comp [#1862] Review > request for Trac Ticket(s): #1682 Peer Reviewer(s): Amf maintainers Pull > request to: > Affected branch(es): All > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset 31a647aa2a6bc4e9b8be7e0b2b82c58c8814064b > Author: Nagendra Kumar<[email protected]> > Date: Thu, 18 Feb 2016 20:34:59 +0530 > > amfnd: delay csi_remove_done for NPI comp [#1682] When an Su > contains one PI > and one NPI comp and if terminate script of NPI comp returns non- > zero, but > cleaup script of NPI returns zero, then during opensafd stop, Amfnd > crashes. > The reason is avnd_comp_csi_remove_done is called from > avnd_comp_clc_terming_cleansucc and SU-SI is deleted inside. > When subsequent > function avnd_comp_clc_st_chng_prc is called Amfnd asserts > because component > doesnt have any csi as it got deleted in > avnd_comp_csi_remove_done. So, > since handling of 'SU Preinst and Comp Non-Preinst' and > 'TERMINATING eq > prv_st and UNINSTANTIATED eq final_st' are in > avnd_comp_clc_st_chng_prc so, > better postpone avnd_comp_csi_remove_done to a later stage as it > happens in > normal scenarion when terminate script of NPI comp return > zero(success). > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/amfnd/clc.cc | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > > Testing Commands: > ----------------- > As per ticket > > Testing, Expected Results: > -------------------------- > Amfnd shouldn't crash > > Conditions of Submission: > ------------------------- > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + > Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor > end-to-end web transactions and take corrective actions now Troubleshoot > faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
