Summary: log: fix info represents by millisecond token is not correct [#1619] Review request for Trac Ticket(s): #1619 Peer Reviewer(s): Lennart, Anders W, Mathi, Vu Pull request to: Lennart Affected branch(es): 4.7, default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset ba42ccf646021ea8b705b451431999d6fe4d77d7 Author: Canh Truong <[email protected]> Date: Tue, 16 Feb 2016 15:24:54 +0700 log: fix info represents by millisecond token is not correct [#1619] The milisecond token (@Ck, @Nk) does not reflect correctly. It is not milisecond in the log record as expectation. This patch fixes the issue. Complete diffstat: ------------------ osaf/services/saf/logsv/lgs/lgs_fmt.cc | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) Testing Commands: ----------------- There is no new test cases added. To test this patch, please do following steps: 1) Change log file format configure for system stream and Notification stream: immcfg -a saLogStreamLogFileFormat='@Cr @Ch:@Cn:@Cs @Cm/@Cd/@CY @Ck @Sv @Sl @Cb' safLgStrCfg=saLogSystem,safApp=safLogService immcfg -a saLogStreamLogFileFormat='@Cr @Ct @Nt @Ne6 @No30 @Ng30 @Nk "@Cb"' safLgStrCfg=saLogNotification,safApp=safLogService 2) Write 20 log records continuously to System and Notification log streams: for i in {1..20}; do saflogger -y "Test ticket 1619 - $i"; saflogger -n "Test ticket 1619 - $i"; done 3) Check milisecond token display in System and Notification log file. Testing, Expected Results: -------------------------- Three digits show in milisecond token increased continuously. Conditions of Submission: ------------------------- Get ack from peer reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
