Summary: base: Add C++ utility functions [#836] Review request for Trac Ticket(s): 836 Peer Reviewer(s): Ramesh Pull request to: Affected branch(es): default(5.0) Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset c9dd036098edc2ab0e9fb8a12e43035e0681a0e4 Author: Anders Widell <[email protected]> Date: Mon, 29 Feb 2016 12:34:56 +0100 base: Add C++ utility functions [#836] Add the following C++ utility functions to the base component: * getenv.h - parsing of environment variables with default values * macros.h - selecting behaviour of copy constructors and assignment operators * process.h - time supervised execution of programs * time.h - conversion to/from POSIX timespec structures Complete diffstat: ------------------ Makefile.common | 3 +- configure.ac | 3 + osaf/libs/core/Makefile.am | 7 ++- osaf/libs/core/cplusplus/Makefile.am | 21 ++++++++++ osaf/libs/core/cplusplus/base/Makefile.am | 42 +++++++++++++++++++++ osaf/libs/core/cplusplus/base/getenv.cc | 160 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/getenv.h | 40 ++++++++++++++++++++ osaf/libs/core/cplusplus/base/macros.h | 33 ++++++++++++++++ osaf/libs/core/cplusplus/base/process.cc | 204 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/process.h | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/tests/Makefile.am | 49 ++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/tests/getenv_test.cc | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/tests/mock_logtrace.cc | 32 ++++++++++++++++ osaf/libs/core/cplusplus/base/tests/mock_logtrace.h | 23 +++++++++++ osaf/libs/core/cplusplus/base/tests/mock_osaf_abort.cc | 25 ++++++++++++ osaf/libs/core/cplusplus/base/tests/mock_osaf_abort.h | 23 +++++++++++ osaf/libs/core/cplusplus/base/tests/mock_osafassert.cc | 27 +++++++++++++ osaf/libs/core/cplusplus/base/tests/mock_osafassert.h | 23 +++++++++++ osaf/libs/core/cplusplus/base/tests/time_add_test.cc | 54 +++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/tests/time_compare_test.cc | 195 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/tests/time_convert_test.cc | 89 ++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/tests/time_subtract_test.cc | 52 ++++++++++++++++++++++++++ osaf/libs/core/cplusplus/base/time.h | 275 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 23 files changed, 1594 insertions(+), 4 deletions(-) Testing Commands: ----------------- make check Testing, Expected Results: -------------------------- Tests should pass Conditions of Submission: ------------------------- Ack from reviewer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
