Summary: amfnd: process su instantiation in a separate thread [#517]
Review request for Trac Ticket(s): #517
Peer Reviewer(s): Amf maintainers
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): Default
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 48963db4c34ac4292eec281fea963461342a016f
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Tue, 15 Mar 2016 12:55:55 +0530
amfnd: process su instantiation in a separate thread [#517] If immnd is
down
and Amf decides to instantiate some SU, then there is a deadlock between
Amfnd and Imm. Amf calls Imm api to read imm attributes during SU
instantiation and stuck because Imm is down. Imm waits for Amfnd to
instantiate/restart it. So, both waits for each other. This is a
deadlock.
So, the fix bypasses main thread for SU instantiation and does process
of SU
instantiation in a separate thread. So, when Imm is down, its
instantiation/restart happens in the main thread. If any SU
instantiation
request comes, then Amfnd routes that request in a separate thread, that
threads stuck in Imm api call untill Imm is not restarted and responds
to
Imm api call. This obviates the deadlock between Amfnd and Imm. So,
this fix
has advantage for not having any mutex between threads. The reason is
that
SU is yet to instantiate, so it is still immune to faults of any
components
and hence no need of having any mutex among the threads.
Added Files:
------------
osaf/services/saf/amf/amfnd/imm.cc
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/Makefile.am | 3 +-
osaf/services/saf/amf/amfnd/evt.cc | 14 ++++++-
osaf/services/saf/amf/amfnd/imm.cc | 137
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/amf/amfnd/include/avnd.h | 6 +++
osaf/services/saf/amf/amfnd/main.cc | 3 +-
5 files changed, 158 insertions(+), 5 deletions(-)
Testing Commands:
-----------------
As per ticket.
Testing, Expected Results:
--------------------------
Amfnd and Imm should not indulge in deadlock.
Conditions of Submission:
-------------------------
Ack from maintainers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
