Summary:ntf: Integrate NTF service with CLM {#1639].
Review request for Trac Ticket(s): #1639
Peer Reviewer(s): Lennart, Minh, Mathi.
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Readme contains the details of implementation.
changeset 7b42980721b50dabfd258fa7548d48822163f8cb
Author: [email protected]
Date: Tue, 15 Mar 2016 18:46:17 +0530
ntf: update README for NTFSv integration with CLM [#1639]
Added information for:
-details of implementation.
-changes at NTFS.
-changes at NTFA.
changeset 1fe5e1b78de794fdf439c5127d19c359de2e6a5d
Author: [email protected]
Date: Tue, 15 Mar 2016 18:47:29 +0530
ntf: add new structure for message from NTFS to NTFA [#1639]
New message structure to be used by NTFS to send CLM membership status
of
node to clients.
changeset e570b6023e943c0214b540379917eb723b1ffead
Author: [email protected]
Date: Tue, 15 Mar 2016 18:48:17 +0530
ntfs: add support for tracking CLM membership related events and act on
them
[#1639]
Changes include:
-subscribe with CLM service to track CLM membership status of nodes.
-send updates to ntf agent whenever there is any change in membership
status
of its node.
-maintain list of member nodes to be used for new clients.
-maintain SAF version of the clients and checkpoint it to standby also.
changeset d1985a623ffc41da0ace1c1ce0cc7505780c6cfe
Author: [email protected]
Date: Tue, 15 Mar 2016 18:48:40 +0530
ntfa: support for returning SA_AIS_ERR_UNAVAILABLE on non-member
node[#1639]
Changes include:
-maintain SAF version.
-minor version is updated from 01 to 02.
-ntfa will get NTFSV_CLM_NODE_STATUS_CALLBACK from NTFS for membership
status
of node.
-check is included in all apis, excluding saNTfFinalize(), to return
SA_AIS_ERR_UNAVAILABLE if node loses CLM membership.
changeset cf59457be3e9d128c045f3c07b6242ce9fedc8a9
Author: [email protected]
Date: Tue, 15 Mar 2016 18:49:08 +0530
ntf/safntf: update SAF version of ntfsend, ntfread and ntfsubscribe
[#1639]
SAF version for ntfsend, ntfread and ntfsubscribe is updated from
A.01.01 to
A.01.02. On a non member node all these commands will exit.
changeset 91ad883a341f3ea025916807384d760a43135438
Author: [email protected]
Date: Tue, 15 Mar 2016 18:49:24 +0530
ntf/tests: add test cases for NTF functionality [#1639]
New file tet_ntf_clm.c contains new test cases for testing this
funtionality. On a non-member node, ntf APIs must return
SA_AIS_ERR_UNAVAILABLE.
Complete diffstat:
------------------
osaf/libs/agents/saf/ntfa/ntfa.h | 3 +
osaf/libs/agents/saf/ntfa/ntfa_api.c | 207
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
osaf/libs/agents/saf/ntfa/ntfa_mds.c | 52 +++++++++++++++
osaf/libs/agents/saf/ntfa/ntfa_util.c | 3 +
osaf/libs/common/ntfsv/include/ntfsv_defs.h | 6 +-
osaf/libs/common/ntfsv/include/ntfsv_msg.h | 7 ++
osaf/services/saf/ntfsv/README | 78 ++++++++++++++++++++++
osaf/services/saf/ntfsv/ntfs/Makefile.am | 2 +
osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 203
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
osaf/services/saf/ntfsv/ntfs/NtfAdmin.hh | 10 ++-
osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 42 ++++++++++++
osaf/services/saf/ntfsv/ntfs/NtfClient.hh | 4 +
osaf/services/saf/ntfsv/ntfs/ntfs.h | 1 +
osaf/services/saf/ntfsv/ntfs/ntfs_cb.h | 5 +
osaf/services/saf/ntfsv/ntfs/ntfs_com.c | 50 +++++++++++++-
osaf/services/saf/ntfsv/ntfs/ntfs_com.h | 23 +++++-
osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 71 ++++++++++++++++++++-
osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 27 +++++++
osaf/services/saf/ntfsv/ntfs/ntfs_mbcsv.c | 48 +++++++++++--
osaf/services/saf/ntfsv/ntfs/ntfs_mbcsv.h | 4 +-
osaf/services/saf/ntfsv/ntfs/ntfs_mds.c | 55 +++++++++++++++
osaf/tools/safntf/ntfread/ntfread.c | 2 +-
osaf/tools/safntf/ntfsend/ntfsend.c | 2 +-
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 2 +-
tests/ntfsv/Makefile.am | 3 +-
tests/ntfsv/tet_ntf_common.h | 7 ++
tests/ntfsv/tet_ntf_main.c | 4 +-
27 files changed, 886 insertions(+), 35 deletions(-)
Testing Commands:
-----------------
1)Brought up a cluster of four nodes and tested NTF APIs on a CLM member node
and on a non member node using CLM lock/unlock admin operation.
3)Tested both A.01.01 and A.01.02 clients on CLM member node and on a non
member node.
4)Borught old ntfs and new ntfs together to verify upgrade procedure.
Testing, Expected Results:
--------------------------
On a member nodes, both A.01.01 and A.01.02 clients works with return status
of SA_AIS_OK
and NTF provides full service.
On a non member node A.01.01 client works with return status of SA_AIS_OK and
NTF provides full service.
On a non member node A.01.02 clients gets ERR_UNAVAILABLE as return status of
APIS.
Conditions of Submission:
-------------------------
Ack from atleast two reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
