Summary: msg: Support up to 4095 nodes [#1613]
Review request for Trac Ticket(s): 1613
Peer Reviewer(s): Mahesh
Pull request to:
Affected branch(es): default(5.0)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 80d61c2bc741bb6c8b76c44f7474c5d281f8a06f
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 18 Mar 2016 16:51:29 +0100
msg: Support up to 4095 nodes [#1613]
Use the new support function GetSlotSubslotIdFromNodeId() to extract a
32-bit integer containing the slot ID and subslot ID from a Node ID.
Complete diffstat:
------------------
osaf/libs/common/mqsv/include/mqa_db.h | 4 +++-
osaf/libs/common/mqsv/include/mqsv_common.h | 2 +-
osaf/libs/common/mqsv/mqsv_common.c | 9 ++-------
osaf/services/saf/mqsv/mqd/mqd_mds.c | 3 ++-
4 files changed, 8 insertions(+), 10 deletions(-)
Testing Commands:
-----------------
This patch should be tested together with all the other patches for ticket 1613.
To test, condfigure a system with more than 255 nodes (i.e. with a node that has
a slot_id greater than 255). Note that you don't actually need to have more than
255 nodes; it is sufficient to test a cluster where some node(s) have a slot_id
greater than 255.
Testing, Expected Results:
--------------------------
OpenSAF shall start an run as normal with nodes whose slot_id is greater than
255.
Conditions of Submission:
-------------------------
Ack from reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
