Hi Hung, Very nice fix.
Reviewed the patch. Ack from me. Thanks, Zoran -----Original Message----- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: Tuesday, March 22, 2016 12:28 PM To: Zoran Milinkovic; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] imm: Fix testcases that release admin owner from safImm object [#1708] tests/immsv/management/test_saImmOmClassCreate_2.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) Fix testcases that release admin owner from safImm object. diff --git a/tests/immsv/management/test_saImmOmClassCreate_2.c b/tests/immsv/management/test_saImmOmClassCreate_2.c --- a/tests/immsv/management/test_saImmOmClassCreate_2.c +++ b/tests/immsv/management/test_saImmOmClassCreate_2.c @@ -385,11 +385,10 @@ static int enableSchemaChange() const SaImmAdminOperationParamsT_2 *params[] = { ¶m, NULL }; SaAisErrorT operation_return_value; - safassert(saImmOmAdminOwnerInitialize(immOmHandle, adminOwnerName, SA_TRUE, &ownerHandle), SA_AIS_OK); + safassert(saImmOmAdminOwnerInitialize(immOmHandle, adminOwnerName, SA_FALSE, &ownerHandle), SA_AIS_OK); safassert(saImmOmAdminOwnerSet(ownerHandle, objectNames, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmAdminOperationInvoke_2(ownerHandle, &objectName, 1, OPENSAF_IMM_NOSTD_FLAG_ON, params, &operation_return_value, SA_TIME_ONE_MINUTE), SA_AIS_OK); - safassert(saImmOmAdminOwnerRelease(ownerHandle, objectNames, SA_IMM_ONE), SA_AIS_OK); done: safassert(saImmOmFinalize(immOmHandle), SA_AIS_OK); @@ -411,11 +410,10 @@ static void disableSchemaChange() SaAisErrorT operation_return_value; safassert(saImmOmInitialize(&immOmHandle, &immOmCallbacks, &immVersion), SA_AIS_OK); - safassert(saImmOmAdminOwnerInitialize(immOmHandle, adminOwnerName, SA_TRUE, &ownerHandle), SA_AIS_OK); + safassert(saImmOmAdminOwnerInitialize(immOmHandle, adminOwnerName, SA_FALSE, &ownerHandle), SA_AIS_OK); safassert(saImmOmAdminOwnerSet(ownerHandle, objectNames, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmAdminOperationInvoke_2(ownerHandle, &objectName, 1, OPENSAF_IMM_NOSTD_FLAG_OFF, params, &operation_return_value, SA_TIME_ONE_MINUTE), SA_AIS_OK); - safassert(saImmOmAdminOwnerRelease(ownerHandle, objectNames, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmFinalize(immOmHandle), SA_AIS_OK); } ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
