Summary:mdstest: tune mdstest code for threads synchronization [#1702]
Review request for Trac Ticket(s): #1702
Peer Reviewer(s): Mathi
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default 5.0 ,4.7
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset ae7fbea94202833f5c8af0276dca88d88a43fbc8
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Mon, 28 Mar 2016 11:49:37 +0530
mdstest: tune mds-test code for threads synchronization [#1702] This is
mdstest threads synchronization code related problem.
If we see in some of the mdstest test cases (for example
tet_send_response_ack_tp_1 ) spawn receiver thread to receive message
send
by main process , using m_NCS_TASK_CREATE and allowing to join using
m_NCS_TASK_RELEASE, and subsequently cleanup is done before concluding
the
test.
Based on debugging , it is evident that the FD which is on osaf_ppoll in
receiver thread is being cleaned/freed by main process , so the FD is
being
called intentional osaf_abort () because of poll FD failed with errno=32
Broken pipe.
So this is thread synchronization issue in MDS test code , so as quick
fix ,
synchronized main process & reviver thread with small sleep , which is
being
used as solution in some test cases.
After # 1522 changes because additional encoding decoding of node name
in
MDS header the send response taking slight higher time then previous so
we
are seeing the issue more offen now , and no function relation relation
between the this issue and Ticket #1522
This patch test result are available in
https://sourceforge.net/p/opensaf/tickets/1702/
Complete diffstat:
------------------
tests/mds/mdstipc.h | 1 +
tests/mds/mdstipc_api.c | 140
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------------
tests/mds/mdstipc_conf.c | 9 +++++++++
3 files changed, 69 insertions(+), 81 deletions(-)
Testing Commands:
-----------------
#run mdstest
Testing, Expected Results:
--------------------------
#mdstest shouldn't coredumps
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
