Summary: amf: send extra state information from nd to d after headless state 
[#1723] 
Review request for Trac Ticket(s): 1723 
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default, 5.0 
Development branch: default 

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y 
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 226a473224096ae0a09635bb740b71c6e87bc6a2
Author: Gary Lee <gary....@dektech.com.au>
Date:   Thu, 07 Apr 2016 13:27:29 +1000

        amf: send extra state information from nd to d after headless state 
[#1723]

        Currently, amfd is not fully aware of each SUSI/CSI's current assignment
        state at amfnd after headless recovery.


Complete diffstat:
------------------
 osaf/libs/common/amf/d2nedu.c                  |  11 ++++++++---
 osaf/libs/common/amf/include/amf_d2nmsg.h      |   3 +++
 osaf/libs/common/amf/include/amf_si_assign.h   |  19 ++++++++-----------
 osaf/services/saf/amf/amfd/csi.cc              |   3 +++
 osaf/services/saf/amf/amfd/include/mds.h       |   7 ++++---
 osaf/services/saf/amf/amfd/mds.cc              |   7 +++++--
 osaf/services/saf/amf/amfd/siass.cc            |  35 
++++++++++++++++++++++++++++++++++-
 osaf/services/saf/amf/amfnd/di.cc              |   7 +++++++
 osaf/services/saf/amf/amfnd/include/avnd_mds.h |   4 ++--
 osaf/services/saf/amf/amfnd/mds.cc             |   6 ++++--
 10 files changed, 78 insertions(+), 24 deletions(-)


Testing Commands:
-----------------
 <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>


Testing, Expected Results:
--------------------------
 <<PASTE COMMAND OUTPUTS / TEST RESULTS>>


Conditions of Submission:
-------------------------
 <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y  
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to