Summary: log: Fix compilation errors [#1743] Review request for Trac Ticket(s): 1743 Peer Reviewer(s): Lennart Pull request to: Affected branch(es): opensaf-5.0.x, default(5.1) Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 11a111306a10374643e51363b5a42ecbc4738fbb Author: Anders Widell <[email protected]> Date: Fri, 08 Apr 2016 17:59:57 +0200 log: Ensure output parameter is always initialized by fileclose_h() [#1743] Initialize the errno_save output parameters in all code paths in the function fileclose_h(), to fix the following compilation error discovered when using GCC 6: In file included from ../../../../../osaf/libs/core/include/ncs_osprm.h:32:0, from ../../../../../osaf/libs/core/include/ncs_ubaid.h:45, from ../../../../../osaf/libs/core/include/mbcsv_papi.h:29, from lgs.h:30, from lgs_stream.cc:29: ../../../../../osaf/libs/core/common/include/logtrace.h: In function 'int log_stream_file_close(log_stream_t*)': ../../../../../osaf/libs/core/common/include/logtrace.h:131:46: error: 'errno_ret' may be used uninitialized in this function [-Werror=maybe- uninitialized] #define LOG_NO(format, args...) _logtrace_log(__FILE__, __LINE__, LOG_NOTICE, (format), ##args) ^ lgs_stream.cc:978:6: note: 'errno_ret' was declared here int errno_ret; ^~~~~~~~~ changeset f4d62e49eb24f10a748f81d10b12a35210ed31d5 Author: Anders Widell <[email protected]> Date: Fri, 08 Apr 2016 17:59:59 +0200 logtest: Remove dead code [#1743] Remove dead code to fix the following compilation error discovered when using GCC 6: tet_Log_recov.c:76:18: error: 'wr_delay' defined but not used [-Werror =unused-const-variable=] static const int wr_delay = 100*1000; /* 100 ms */ ^~~~~~~~ Complete diffstat: ------------------ osaf/services/saf/logsv/lgs/lgs_stream.cc | 1 + tests/logsv/tet_Log_recov.c | 2 -- 2 files changed, 1 insertions(+), 2 deletions(-) Testing Commands: ----------------- Build OpenSAF with GCC 6 and run regression tests. Testing, Expected Results: -------------------------- OpenSAF should build successfully and regression tests should pass. Conditions of Submission: ------------------------- Ack from reviewer(s) Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
