Summary: amfnd: remove receive message id counter from threads [#1728]
Review request for Trac Ticket(s): #1728
Peer Reviewer(s): Amf developers
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 5.0 and default
Development branch: 5.0
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 71b86f3732bae2e5ccdb2d721ca06ed8cf0b570f
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Mon, 11 Apr 2016 17:13:25 +0530
amfnd: remove receive message id counter from threads [#1728] Since, the
message id counter is updated by main thread and imm reader thread
simultaneouspy, so there is chance that the counter may be updated in
any
order and make Amfd and Amfnd counters Out of Order. So, such msg id
counter
update should be removed from both and should be kep at a common
location.
This patch fixes the same.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/amfnd.cc | 3 --
osaf/services/saf/amf/amfnd/comp.cc | 3 --
osaf/services/saf/amf/amfnd/di.cc | 24 ---------------------
osaf/services/saf/amf/amfnd/mds.cc | 89
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/amf/amfnd/su.cc | 12 ----------
osaf/services/saf/amf/amfnd/susm.cc | 9 -------
osaf/services/saf/amf/amfnd/term.cc | 4 ---
7 files changed, 89 insertions(+), 55 deletions(-)
Testing Commands:
-----------------
Keep sleep of 10 sec in avnd_evt_avd_su_pres_evh() and
start single controller, Amfnd aborts.
Apr 11 16:13:36 PM_SC-1 osafamfnd[3506]: Rebooting OpenSAF NodeId = 0 EE Name =
No EE Mapped, Reason: Message ID mismatch, rec 5, expected 4, OwnNodeId =
131343, SupervisionTime = 60
Testing, Expected Results:
--------------------------
No crash with the patch applied.
Conditions of Submission:
-------------------------
Ack from Amf Developers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/
gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
