Hi Hung, Reviewed and tested the patch. Ack.
/Neel. On Thursday 07 April 2016 03:48 PM, Hung Nguyen wrote: > Summary: immtools: Use safe read to retrieve class name for immcfg [#1726] > Review request for Trac Ticket(s): 1726 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 5.0, 5.1 > Development branch: 5.1 > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 741280c250a2760b32da523ab8f39be4ffbb105d > Author: Hung Nguyen <hung.d.ngu...@dektech.com.au> > Date: Thu, 07 Apr 2016 16:37:51 +0700 > > immtools: Use safe read to retrieve class name for immcfg [#1726] > > This patch revert ticket #1283 and use safe read to retrieve class name > for > chained modify operations. > > > Complete diffstat: > ------------------ > osaf/tools/safimm/immcfg/imm_cfg.c | 149 > +++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------- > osaf/tools/safimm/immcfg/imm_import.cc | 14 +++-------- > 2 files changed, 53 insertions(+), 110 deletions(-) > > > Testing Commands: > ----------------- > time immcfg -f 20k_objects.xml > see ticket description for the xml file. > > > Testing, Expected Results: > -------------------------- > immcfg gets better performance when working with a large number of objects. > > > Conditions of Submission: > ------------------------- > Ack from reviewers. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
