Hi Vu, I think that situation can indeed occur.
Ack, Mathi. > -----Original Message----- > From: Vu Minh Nguyen [mailto:[email protected]] > Sent: Thursday, April 14, 2016 3:12 PM > To: Mathivanan Naickan Palanivelu; [email protected] > Cc: [email protected] > Subject: RE: [PATCH 1 of 1] log: fix the initialized log handle is deleted > when > initializing with unsupported version [#1739] > > Hi Mathi, > > I have based two things: > > 1) The API calling sequence: > > 100|0|Invoking saLogInitialize() // (1) > 100|0| Return value : <-- SA_AIS_OK > 100|0| Handle obtained is 4290772993 > 100|0|Invoking saLogStreamOpen_2() > 100|0|Handle used is 4290772993 > 100|0| Return value : <-- SA_AIS_OK > 100|0| Handle obtained is *4288675841* > ........................... // (2) > 100|0|Invoking saLogInitialize() // (3) > 100|0| Return value : <-- SA_AIS_OK > 100|0| Handle obtained is *4288675841* > > I guess that, in <........> - point (2), there was an call to initialize LOG > with > unsupported version. > If so, the handle obtained previously was deleted secretly, means Handle > Manager freed/reset the handle ID. As the result, next initializing() - point > (3), there is an room for Handle Manager to allocate the new handle with > same handle ID as previous call - point (1). > > 2) The reported issue have not seen on OpenSAF 4.7 The point fixing in this > patch has impact to Handle ID allocator that just been changed in OpenSAF > 5.0. > > If you think it is not logic, I will create another OpenSAF ticket for this > instead. > > Regards, Vu. > > >-----Original Message----- > >From: Mathivanan Naickan Palanivelu [mailto:[email protected]] > >Sent: Thursday, April 14, 2016 3:50 PM > >To: [email protected] > >Cc: [email protected]; [email protected] > >Subject: Re: [PATCH 1 of 1] log: fix the initialized log handle is > >deleted when initializing with unsupported version [#1739] > > > >Hi Vu, > > > >Iam trying to understand the fix and its connection to the problem > >reported in the ticket. > >Could you give a brief explanation. > > > >Thanks, > >Mathi. > > > >----- [email protected] wrote: > > > >> osaf/libs/agents/saf/lga/lga_api.c | 1 - > >> 1 files changed, 0 insertions(+), 1 deletions(-) > >> > >> > >> When initializing LOG with unsupported version, previous initialized > >> log handle was deleted unexpectedly. > >> > >> The patch will fix above problem. > >> > >> diff --git a/osaf/libs/agents/saf/lga/lga_api.c > >> b/osaf/libs/agents/saf/lga/lga_api.c > >> --- a/osaf/libs/agents/saf/lga/lga_api.c > >> +++ b/osaf/libs/agents/saf/lga/lga_api.c > >> @@ -145,7 +145,6 @@ SaAisErrorT saLogInitialize(SaLogHandleT > >> version->releaseCode = LOG_RELEASE_CODE; > >> version->majorVersion = LOG_MAJOR_VERSION; > >> version->minorVersion = LOG_MINOR_VERSION; > >> - lga_shutdown_after_last_client(); > >> ais_rc = SA_AIS_ERR_VERSION; > >> goto done; > >> } > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
