Summary: imm: Finalize search node if there are errors when fetching pure rt attributes [#1776] Review request for Trac Ticket(s): 1776 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 4.6, 4.7, 5.0, 5.1 Development branch: 5.1
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 03e8b9d76bef2ac3c82498f01552517589eb2b95 Author: Hung Nguyen <[email protected]> Date: Tue, 26 Apr 2016 12:42:04 +0700 imm: Finalize search node if there are errors when fetching pure rt attributes [#1776] If OI returns ERR_NO_MEMORY or ERR_NO_RESOURCES, the iteration will not move to the next object. Application can then try SearchNext() again to read the object. This is implemented by postponing popping out the object from mResultList until receiving response from OI. If there's an OI response time out, the search node will be finalized. Application will get ERR_BAD_HANDLE in the next attempt at calling SearchNext(). Complete diffstat: ------------------ osaf/services/saf/immsv/immnd/ImmModel.cc | 19 +++++++++++++++++++ osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 7 +++++-- osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 1 + osaf/services/saf/immsv/immnd/immnd_evt.c | 12 +++++++++++- osaf/services/saf/immsv/immnd/immnd_init.h | 2 ++ 5 files changed, 38 insertions(+), 3 deletions(-) Testing Commands: ----------------- Please see the ticket description. Testing, Expected Results: -------------------------- Please see the ticket description. Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
