Summary: amfnd: fix amfnd crash during su and node level escalations [#1770]
Review request for Trac Ticket(s): #1770
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 29a209d06129ff31dda3d078b462a639e99b11a5
Author: praveen.malv...@oracle.com
Date: Thu, 28 Apr 2016 12:43:13 +0530
amfnd: fix amfnd crash during su and node level escalations [#1770]
AMFND crashes during sufailover recovery which resulted because of CSI
remove callback timeout in su lock operation.
Applicable to sufailover, node-failover and node-switchover along with
su-
failover. AMFND calls oper_done logic multiple times. This logic must be
called when AMFND has to respond to AMFD for pending assignments. In
these
recovery policies, AMFD will perform recovery of assignments on
escalation
request. So calling oper_done logic for these recoveries must be
avoided in
AMFND.
Patach solves problem by resetting the pending assignment flag in SU for
these recovery policies. AMFD will perform recovery when it gets
recovery
request from AMFND.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/err.cc | 18 ++++++++++++++++++
1 files changed, 18 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Tested with the simple conf that I have attched in the ticket.
Tested for su-failover, node-switchover (sufailver flag true) and node-failover.
Testing, Expected Results:
--------------------------
No crash observed.
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
